You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2009/04/06 07:03:13 UTC
[jira] Created: (HADOOP-5628) Create target for 10 minute patch
test build
Create target for 10 minute patch test build
--------------------------------------------
Key: HADOOP-5628
URL: https://issues.apache.org/jira/browse/HADOOP-5628
Project: Hadoop Core
Issue Type: Bug
Components: test
Reporter: Owen O'Malley
I think we should create an ant target that performs a smoke test on the patched system to enable developers to have faster turn around time on developing patches than the 3 hour unit tests that we currently have.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5628) Create target for 10 minute patch
test build
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695978#action_12695978 ]
Owen O'Malley commented on HADOOP-5628:
---------------------------------------
I propose that we take the test-patch target name and have it:
1. Run javac, javadoc, findbugs, and release audit tool and report any new violations. Since this is for developers, we shouldn't force them to make a patch and make a clean work directory, but assume the patch has been applied to the work directory. That means we need to either clean up or suppress all of the warnings, especially from javac and findbugs.
2. Run some unit tests that aim for breadth of coverage.
Try and keep the whole thing under 10 minutes so that developers that are trying to test their patches aren't spending hours in the edit-test patch that is currently happening.
The other tests should be kept and run as often as possible.
> Create target for 10 minute patch test build
> --------------------------------------------
>
> Key: HADOOP-5628
> URL: https://issues.apache.org/jira/browse/HADOOP-5628
> Project: Hadoop Core
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
>
> I think we should create an ant target that performs a smoke test on the patched system to enable developers to have faster turn around time on developing patches than the 3 hour unit tests that we currently have.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5628) Create target for 10 minute patch
test build
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695984#action_12695984 ]
Nigel Daley commented on HADOOP-5628:
-------------------------------------
Ya, all the warnings need to go to zero (like javadoc). +1 for that, as long as we evaluate them carefully before suppressing them.
I think this will also require we categorize our unit tests into fast and slow. This will require TestNG or Junit 4.5 (my vote is for TestNG). See HADOOP-4901. +1 for that too.
> Create target for 10 minute patch test build
> --------------------------------------------
>
> Key: HADOOP-5628
> URL: https://issues.apache.org/jira/browse/HADOOP-5628
> Project: Hadoop Core
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
>
> I think we should create an ant target that performs a smoke test on the patched system to enable developers to have faster turn around time on developing patches than the 3 hour unit tests that we currently have.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5628) Create target for 10 minute patch
test build
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696488#action_12696488 ]
Jothi Padmanabhan commented on HADOOP-5628:
-------------------------------------------
The current trunk has 1000 deprecated warnings from the mapred package. All of these warnings are because of deprecation of old-api related classes in favor of the new-api.
Is there a way by which we can do a blanket suppression of deprecated warnings, possibly from javac command line? What is a good way to handle this?
> Create target for 10 minute patch test build
> --------------------------------------------
>
> Key: HADOOP-5628
> URL: https://issues.apache.org/jira/browse/HADOOP-5628
> Project: Hadoop Core
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
>
> I think we should create an ant target that performs a smoke test on the patched system to enable developers to have faster turn around time on developing patches than the 3 hour unit tests that we currently have.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5628) Create target for 10 minute patch
test build
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713542#action_12713542 ]
Tom White commented on HADOOP-5628:
-----------------------------------
The following ant argument will suppress all deprecated warnings, while keeping the other Xlint warnings:
{noformat}
-Djavac.args="-Xlint -Xlint:-deprecation -Xmaxwarns 1000"
{noformat}
I don't think you can suppress deprecated warnings on a per-package basis. While we have so many deprecated classes in the old mapred package, I think that blanket suppression is the most pragmatic approach for this new patch target.
bq. I think this will also require we categorize our unit tests into fast and slow.
Or perhaps into unit test vs. functional or integration test.
> Create target for 10 minute patch test build
> --------------------------------------------
>
> Key: HADOOP-5628
> URL: https://issues.apache.org/jira/browse/HADOOP-5628
> Project: Hadoop Core
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
>
> I think we should create an ant target that performs a smoke test on the patched system to enable developers to have faster turn around time on developing patches than the 3 hour unit tests that we currently have.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.