[GitHub] [hive] zabetak commented on a change in pull request #3067: HIVE-25997: Fix release source packaging

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #3067:
URL: https://github.com/apache/hive/pull/3067#discussion_r817557491



##########
File path: packaging/src/main/assembly/src.xml
##########
@@ -100,12 +100,26 @@
         <include>storage-api/**/*</include>

Review comment:
       This is unrelated to the changes here but it is kind of weird that we are packing in the source packages of Hive a project/module (`storage-api`) that has it's own release cycle. If we are including the sources here then we are somewhat releasing the storage-api multiple times.

##########
File path: packaging/src/main/assembly/src.xml
##########
@@ -100,12 +100,26 @@
         <include>storage-api/**/*</include>
         <include>standalone-metastore/metastore-common/**/*</include>
         <include>standalone-metastore/metastore-server/**/*</include>
+        <include>standalone-metastore/metastore-tools/**/*</include>
+        <include>standalone-metastore/src/assembly/src.xml</include>
+        <include>standalone-metastore/pom.xml</include>

Review comment:
       Honestly, I am not sure what is the proper solution here. The `standalone-metastore` was separated in HIVE-17159 so that it gets its own release life-cycle. Since 2017, though I don't think this ever happened in practice. My concern here is the same with `storage-api`. We shouldn't be releasing the same code twice.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org