You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by krish i <kr...@gmail.com> on 2016/03/05 23:41:31 UTC

Review Request 44430: Updating documentation Update configuration-reference.md documentation on supporting private docker registry.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44430/
-----------------------------------------------------------

Review request for Aurora.


Repository: aurora


Description
-------

Updaitng documentation There is no parameter in aurora v0.11 named enable_docker_parameters However, there is a parameter called allow_docker_parameters

root@5f08778c5d24:/# aurora-scheduler -help | grep docker
-allow_docker_parameters=false
   Allow to pass docker container parameters in the job.
   (org.apache.aurora.scheduler.configuration.ConfigurationManager.allow_docker_parameters)


Diffs
-----

  docs/configuration-reference.md 3f023d77e1f8a1cc13abeaba9a4b69879f42bba4 

Diff: https://reviews.apache.org/r/44430/diff/


Testing
-------


Thanks,

krish i


Re: Review Request 44430: Updating documentation Update configuration-reference.md documentation on supporting private docker registry.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44430/#review122213
-----------------------------------------------------------


Ship it!




Master (a91a759) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 5, 2016, 10:41 p.m., krish i wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44430/
> -----------------------------------------------------------
> 
> (Updated March 5, 2016, 10:41 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Updaitng documentation There is no parameter in aurora v0.11 named enable_docker_parameters However, there is a parameter called allow_docker_parameters
> 
> root@5f08778c5d24:/# aurora-scheduler -help | grep docker
> -allow_docker_parameters=false
>    Allow to pass docker container parameters in the job.
>    (org.apache.aurora.scheduler.configuration.ConfigurationManager.allow_docker_parameters)
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 3f023d77e1f8a1cc13abeaba9a4b69879f42bba4 
> 
> Diff: https://reviews.apache.org/r/44430/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> krish i
> 
>