You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Stefano Bagnara <ap...@bago.org> on 2008/12/03 12:12:34 UTC
DKIM library / mailet
Hi all,
I hope to find soon the time to work on DKIM for JAMES.
I'll start reviewing Tom Brown code at
http://issues.apache.org/jira/browse/JAMES-752
1) The code is 2 years old and has no license headers. The author
granted rights for inclusion. Can we commit it (adding license headers)?
2) The issue with the Yahoo patent:
https://datatracker.ietf.org/ipr/693/
Here is the result of "legal" submittion:
https://issues.apache.org/jira/browse/LEGAL-22 (My english is not good
enough to understand Ruby/Yandell discussion about "concern" vs "cause
any concerns").
http://www.apache.org/legal/resolved.html says:
- Q: Does the Yahoo! DomainKeys Patent License Agreement v1.2 raise any
concerns?
- A: No.
I don't care if it raise "concerns" or not, I'd like to know if ASF can
create and redistribute an implementation of the DKIM specification. :-)
3) Where should I commit it? It uses the java.security package, so maybe
crypto mailet? or another top level library (jDKIM) ?
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: DKIM library / mailet
Posted by Stefano Bagnara <ap...@bago.org>.
Tom Brown ha scritto:
> Yes, the original author is still around.
>
> What sorts of headers are normally used for code like this?
Hi Tom :-)
ASF requires the use of ASF header on top of each file:
----------------
/****************************************************************
* Licensed to the Apache Software Foundation (ASF) under one *
* or more contributor license agreements. See the NOTICE file *
* distributed with this work for additional information *
* regarding copyright ownership. The ASF licenses this file *
* to you under the Apache License, Version 2.0 (the *
* "License"); you may not use this file except in compliance *
* with the License. You may obtain a copy of the License at *
* *
* http://www.apache.org/licenses/LICENSE-2.0 *
* *
* Unless required by applicable law or agreed to in writing, *
* software distributed under the License is distributed on an *
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
* KIND, either express or implied. See the License for the *
* specific language governing permissions and limitations *
* under the License. *
****************************************************************/
----------------
and discourage the use of the @author tags:
----------------
/**
* @author TBrown
*
* TODO To change the template for this generated type comment go to
* Window - Preferences - Java - Code Style - Code Templates
*/
----------------
If you do that change on that code it will be more clear your intention
to contribute the code to the foundation.
I've just tried to build the code and I'd like to make it "sun" JVM
independent. It now uses base64 code from sun jvm "private" packages and
also some RSA* classes that should probably be retrieved via some public
factory... but I have to study it and my old GPG code to remeber how
that crypto stuff work :-)
I've also contacted the authors of JavaDKIM
(http://www.badpenguin.co.uk/main/content/view/62/1/) and DKIM for
JavaMail
(http://www.agitos.de/dkim-for-java-mail-open-source-library-2.html) to
know if they are interested in merging the efforts in a single library.
Also, Florian Sager (author of DKIM for JavaMail) expressed his interest
in creating some integration point to www.dkim-reputation.org
I'd like to create a multimodule project for dkim, because I think it is
better to separate a generic java dkim library from the mailets and then
have the mailet/matchers based on that code in a separate module, but
first I want to better study the RFC and understand the differences
between DomainKeys and DKIM (and the status of the Author Domain Signing
Practices / SSP). (e.g: ADSP may belong to its own module, and maybe
some of the jSPF test suite will help testing this one too)
Stefano
> On Wed, Dec 3, 2008 at 5:45 AM, Robert Burrell Donkin
> <ro...@gmail.com> wrote:
>> On Wed, Dec 3, 2008 at 11:12 AM, Stefano Bagnara <ap...@bago.org> wrote:
>>> Hi all,
>>>
>>> I hope to find soon the time to work on DKIM for JAMES.
>>> I'll start reviewing Tom Brown code at
>>> http://issues.apache.org/jira/browse/JAMES-752
>> cool
>>
>>> 1) The code is 2 years old and has no license headers. The author
>>> granted rights for inclusion. Can we commit it (adding license headers)?
>> yes
>>
>> i would recommend trying to involve the original contributor (if he's
>> still around). update the issue now with your intentions and see
>> whether he's still around. if so, then give him a chance to tidy up
>> the code, add headers etc, file an ICLA. if he doesn't show up then
>> it's fine just to go ahead but it's worth trying to recruit him for
>> the effort.
>>
>>> 2) The issue with the Yahoo patent:
>>> https://datatracker.ietf.org/ipr/693/
>>>
>>> Here is the result of "legal" submittion:
>>> https://issues.apache.org/jira/browse/LEGAL-22 (My english is not good
>>> enough to understand Ruby/Yandell discussion about "concern" vs "cause
>>> any concerns").
>> it's general verses specific
>>
>> (people at) apache may well be concerned about software patents (in
>> general) , or about Yahoo's strategy, or whatever
>>
>> using 'cause any concerns' addresses the narrow question only
>>
>>> http://www.apache.org/legal/resolved.html says:
>>> - Q: Does the Yahoo! DomainKeys Patent License Agreement v1.2 raise any
>>> concerns?
>>> - A: No.
>>>
>>> I don't care if it raise "concerns" or not, I'd like to know if ASF can
>>> create and redistribute an implementation of the DKIM specification. :-)
>> it's good enough, i think
>>
>>> 3) Where should I commit it? It uses the java.security package, so maybe
>>> crypto mailet? or another top level library (jDKIM) ?
>> for legal reasons, i recommend isolating the code and not including it
>> as part of james 3 codebase. this limits any potential damage if the
>> legal call turns out to be wrong.
>>
>> i would see the choice as lying between a simple mailet library in
>> james/mailet/ and a modular project at top level (library plus mailet
>> like JSieve). we should link to the mailet from the main mailet page
>> in either case.
>>
>> - robert
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: DKIM library / mailet
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On 12/8/08, Tom Brown <to...@gmail.com> wrote:
> Yes, the original author is still around.
Great :-)
> What sorts of headers are normally used for code like this?
All Apache source (that can reasonable contain it) should have the
standard boilerplate. See http://www.apache.org/legal/src-headers for
the complete picture if just copy the header from any existing James
source (they're all the same).
(Just FYI http://www.apache.org/dev contains lots of developer
oriented information)
Robert
>
> Tom
>
> On Wed, Dec 3, 2008 at 5:45 AM, Robert Burrell Donkin
> <ro...@gmail.com> wrote:
>> On Wed, Dec 3, 2008 at 11:12 AM, Stefano Bagnara <ap...@bago.org> wrote:
>>> Hi all,
>>>
>>> I hope to find soon the time to work on DKIM for JAMES.
>>> I'll start reviewing Tom Brown code at
>>> http://issues.apache.org/jira/browse/JAMES-752
>>
>> cool
>>
>>> 1) The code is 2 years old and has no license headers. The author
>>> granted rights for inclusion. Can we commit it (adding license headers)?
>>
>> yes
>>
>> i would recommend trying to involve the original contributor (if he's
>> still around). update the issue now with your intentions and see
>> whether he's still around. if so, then give him a chance to tidy up
>> the code, add headers etc, file an ICLA. if he doesn't show up then
>> it's fine just to go ahead but it's worth trying to recruit him for
>> the effort.
>>
>>> 2) The issue with the Yahoo patent:
>>> https://datatracker.ietf.org/ipr/693/
>>>
>>> Here is the result of "legal" submittion:
>>> https://issues.apache.org/jira/browse/LEGAL-22 (My english is not good
>>> enough to understand Ruby/Yandell discussion about "concern" vs "cause
>>> any concerns").
>>
>> it's general verses specific
>>
>> (people at) apache may well be concerned about software patents (in
>> general) , or about Yahoo's strategy, or whatever
>>
>> using 'cause any concerns' addresses the narrow question only
>>
>>> http://www.apache.org/legal/resolved.html says:
>>> - Q: Does the Yahoo! DomainKeys Patent License Agreement v1.2 raise any
>>> concerns?
>>> - A: No.
>>>
>>> I don't care if it raise "concerns" or not, I'd like to know if ASF can
>>> create and redistribute an implementation of the DKIM specification. :-)
>>
>> it's good enough, i think
>>
>>> 3) Where should I commit it? It uses the java.security package, so maybe
>>> crypto mailet? or another top level library (jDKIM) ?
>>
>> for legal reasons, i recommend isolating the code and not including it
>> as part of james 3 codebase. this limits any potential damage if the
>> legal call turns out to be wrong.
>>
>> i would see the choice as lying between a simple mailet library in
>> james/mailet/ and a modular project at top level (library plus mailet
>> like JSieve). we should link to the mailet from the main mailet page
>> in either case.
>>
>> - robert
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: DKIM library / mailet
Posted by Tom Brown <to...@gmail.com>.
Yes, the original author is still around.
What sorts of headers are normally used for code like this?
Tom
On Wed, Dec 3, 2008 at 5:45 AM, Robert Burrell Donkin
<ro...@gmail.com> wrote:
> On Wed, Dec 3, 2008 at 11:12 AM, Stefano Bagnara <ap...@bago.org> wrote:
>> Hi all,
>>
>> I hope to find soon the time to work on DKIM for JAMES.
>> I'll start reviewing Tom Brown code at
>> http://issues.apache.org/jira/browse/JAMES-752
>
> cool
>
>> 1) The code is 2 years old and has no license headers. The author
>> granted rights for inclusion. Can we commit it (adding license headers)?
>
> yes
>
> i would recommend trying to involve the original contributor (if he's
> still around). update the issue now with your intentions and see
> whether he's still around. if so, then give him a chance to tidy up
> the code, add headers etc, file an ICLA. if he doesn't show up then
> it's fine just to go ahead but it's worth trying to recruit him for
> the effort.
>
>> 2) The issue with the Yahoo patent:
>> https://datatracker.ietf.org/ipr/693/
>>
>> Here is the result of "legal" submittion:
>> https://issues.apache.org/jira/browse/LEGAL-22 (My english is not good
>> enough to understand Ruby/Yandell discussion about "concern" vs "cause
>> any concerns").
>
> it's general verses specific
>
> (people at) apache may well be concerned about software patents (in
> general) , or about Yahoo's strategy, or whatever
>
> using 'cause any concerns' addresses the narrow question only
>
>> http://www.apache.org/legal/resolved.html says:
>> - Q: Does the Yahoo! DomainKeys Patent License Agreement v1.2 raise any
>> concerns?
>> - A: No.
>>
>> I don't care if it raise "concerns" or not, I'd like to know if ASF can
>> create and redistribute an implementation of the DKIM specification. :-)
>
> it's good enough, i think
>
>> 3) Where should I commit it? It uses the java.security package, so maybe
>> crypto mailet? or another top level library (jDKIM) ?
>
> for legal reasons, i recommend isolating the code and not including it
> as part of james 3 codebase. this limits any potential damage if the
> legal call turns out to be wrong.
>
> i would see the choice as lying between a simple mailet library in
> james/mailet/ and a modular project at top level (library plus mailet
> like JSieve). we should link to the mailet from the main mailet page
> in either case.
>
> - robert
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: DKIM library / mailet
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Wed, Dec 3, 2008 at 11:12 AM, Stefano Bagnara <ap...@bago.org> wrote:
> Hi all,
>
> I hope to find soon the time to work on DKIM for JAMES.
> I'll start reviewing Tom Brown code at
> http://issues.apache.org/jira/browse/JAMES-752
cool
> 1) The code is 2 years old and has no license headers. The author
> granted rights for inclusion. Can we commit it (adding license headers)?
yes
i would recommend trying to involve the original contributor (if he's
still around). update the issue now with your intentions and see
whether he's still around. if so, then give him a chance to tidy up
the code, add headers etc, file an ICLA. if he doesn't show up then
it's fine just to go ahead but it's worth trying to recruit him for
the effort.
> 2) The issue with the Yahoo patent:
> https://datatracker.ietf.org/ipr/693/
>
> Here is the result of "legal" submittion:
> https://issues.apache.org/jira/browse/LEGAL-22 (My english is not good
> enough to understand Ruby/Yandell discussion about "concern" vs "cause
> any concerns").
it's general verses specific
(people at) apache may well be concerned about software patents (in
general) , or about Yahoo's strategy, or whatever
using 'cause any concerns' addresses the narrow question only
> http://www.apache.org/legal/resolved.html says:
> - Q: Does the Yahoo! DomainKeys Patent License Agreement v1.2 raise any
> concerns?
> - A: No.
>
> I don't care if it raise "concerns" or not, I'd like to know if ASF can
> create and redistribute an implementation of the DKIM specification. :-)
it's good enough, i think
> 3) Where should I commit it? It uses the java.security package, so maybe
> crypto mailet? or another top level library (jDKIM) ?
for legal reasons, i recommend isolating the code and not including it
as part of james 3 codebase. this limits any potential damage if the
legal call turns out to be wrong.
i would see the choice as lying between a simple mailet library in
james/mailet/ and a modular project at top level (library plus mailet
like JSieve). we should link to the mailet from the main mailet page
in either case.
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org