You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/26 02:36:54 UTC

[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #2610: binary mathematical operators work with `NULL`

jackwener commented on code in PR #2610:
URL: https://github.com/apache/arrow-datafusion/pull/2610#discussion_r882265217


##########
datafusion/expr/src/binary_rule.rs:
##########
@@ -282,7 +282,7 @@ fn mathematics_numerical_coercion(
     use arrow::datatypes::DataType::*;
 
     // error on any non-numeric type

Review Comment:
   ```suggestion
       // error on any not numeric/null type
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org