Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.

[Sachchidanand Vaidya <va...@juniper.net>]

Hi,
    Can someone pls. review these changes.

Thanks & Regards,
Sachin

From: Sachchidanand Vaidya <va...@juniper.net>>
Reply-To: Sachchidanand Vaidya <va...@juniper.net>>
Date: Thursday, March 27, 2014 4:38 PM
To: Sachchidanand Vaidya <va...@juniper.net>>, cloudstack <de...@cloudstack.apache.org>>
Subject: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19758/

Review request for cloudstack.
By Sachchidanand Vaidya.
Repository: cloudstack-git
Description

 - Added new Network Service Provider "JuniperContrailvSRX".
 - Impelemted an element (ContrailVSrxElement) to support this Network Service Provider.
   vSRX element currently supports only sourceNAT. It will be enhanced later to support
   more features.
 - Changes to service-instance creation code to use left virtual-network's SourceNAT addr
   as an interface address on vSRX instance's Public-network interface.



Testing

Performed unit tests with vSRX network service provider. Also other unit tests pass in local testbed.


Diffs

  *   api/src/com/cloud/network/Network.java (ef3bcdf)
  *   plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml (99ab02e)
  *   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java (PRE-CREATION)
  *   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java (f34eacc)
  *   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java (49060f1)

View Diff<https://reviews.apache.org/r/19758/diff/>