You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mingjie Lai (JIRA)" <ji...@apache.org> on 2011/07/07 01:25:16 UTC
[jira] [Created] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
[Coprocessors] Improve region server metrics to report loaded coprocessors to master
------------------------------------------------------------------------------------
Key: HBASE-4070
URL: https://issues.apache.org/jira/browse/HBASE-4070
Project: HBase
Issue Type: Improvement
Affects Versions: 0.90.3
Reporter: Mingjie Lai
HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122150#comment-13122150 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2398
-----------------------------------------------------------
Looks good to me. Ship it after some minor fixes.
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
<https://reviews.apache.org/r/2029/#comment5502>
masterCoprocessors is a string array. I don't think you can use equals() here.
If the 2 arrays are sorted, you may use Arrays.equals().
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5507>
This is cool.
Array.toString() can return null. You want to check?
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5509>
As above: Arrays.toString() can be null.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
<https://reviews.apache.org/r/2029/#comment5508>
can you finish the TODO?
- Mingjie
On 2011-10-05 21:45:30, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-05 21:45:30)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131133#comment-13131133 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
bq. On 2011-10-19 21:34:00, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 78
bq. > <https://reviews.apache.org/r/2029/diff/11/?file=50347#file50347line78>
bq. >
bq. > Is this a 'load'? Or is this an attribute of the server? We used to have an HServerInfo. This looks like something that would belong in there rather than in HSL?
Hi Michael,
As Ted mentioned, HServerInfo is deprecated (per https://issues.apache.org/jira/browse/HBASE-1502) .
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2678
-----------------------------------------------------------
On 2011-10-16 16:22:16, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-16 16:22:16)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 7d2f82e
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java e2e694a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() added to (existing) src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127810#comment-13127810 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
bq. On 2011-10-06 18:44:31, Mingjie Lai wrote:
bq. > src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java, line 378
bq. > <https://reviews.apache.org/r/2029/diff/8/?file=48373#file48373line378>
bq. >
bq. > can you finish the TODO?
Added more testing for loaded-coprocessor reporting as it relates to user tables' being loaded and unloaded in testRegionServerCoprocessorsReported().
bq. On 2011-10-06 18:44:31, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 542
bq. > <https://reviews.apache.org/r/2029/diff/8/?file=48368#file48368line542>
bq. >
bq. > As above: Arrays.toString() can be null.
Checking for null return value from Arrays.toStrings() : thanks for catching this.
bq. On 2011-10-06 18:44:31, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 448
bq. > <https://reviews.apache.org/r/2029/diff/8/?file=48368#file48368line448>
bq. >
bq. > This is cool.
bq. >
bq. > Array.toString() can return null. You want to check?
Checking for null here: thanks for catching this.
bq. On 2011-10-06 18:44:31, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/ClusterStatus.java, line 162
bq. > <https://reviews.apache.org/r/2029/diff/8/?file=48367#file48367line162>
bq. >
bq. > masterCoprocessors is a string array. I don't think you can use equals() here.
bq. >
bq. > If the 2 arrays are sorted, you may use Arrays.equals().
Using Arrays.equals() rather than String[].equals - you are right; thanks for catching this.
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2398
-----------------------------------------------------------
On 2011-10-14 19:50:47, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-14 19:50:47)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. .gitignore a8a9adc
bq. conf/hbase-site.xml af4c300
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 7d2f82e
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java e2e694a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119843#comment-13119843 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-10-04 01:21:46.559878)
Review request for hbase and Mingjie Lai.
Changes
-------
Address Andrew Purtell's review of patch version 5:
-replace "coprocessor(s)name(s)" with "coprocessor(s)".
-HServerLoad and RegionLoad use Set<String> rather than Set<CoprocessorEnvironment> to represent coprocessors.
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs (updated)
-----
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117849#comment-13117849 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-09-30 03:29:57.261186)
Review request for hbase and Mingjie Lai.
Changes
-------
Address reviews by Andrew Purtell and Mingjie Lai.
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 270f3f3
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
Diff: https://reviews.apache.org/r/2029/diff
Testing (updated)
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118209#comment-13118209 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2222
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5157>
Should return String[]? Trivial to do here given the data is in a Set. Then callers can enumerate.
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5156>
Make a list of unique names for HSL instead of a string?
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<https://reviews.apache.org/r/2029/#comment5155>
Should return String[]? Trivial to do here given the data is in a Set.
Then callers can enumerate. Easy enough to display a list of strings in the jamon templates.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/2029/#comment5154>
Should return String[]? Then callers can enumerate. Easy enough to display a list of strings in the jamon templates.
- Andrew
On 2011-09-30 04:58:20, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-30 04:58:20)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127967#comment-13127967 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2607
-----------------------------------------------------------
Ship it!
Looks good to me.
- Mingjie
On 2011-10-14 22:45:37, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-14 22:45:37)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 7d2f82e
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java e2e694a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117655#comment-13117655 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
bq. On 2011-09-29 21:52:40, Andrew Purtell wrote:
bq. >
Actually, I do have a comment. Do we need a method in HMasterInterface for getting the coprocessor set? Can't it be extracted from HSL?
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2179
-----------------------------------------------------------
On 2011-09-29 20:15:12, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 20:15:12)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java a069400
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 270f3f3
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/main/ruby/hbase/admin.rb b244ffe
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java a8f2a9c
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() added to src/test/java/o.a.h.h/coprocessor/TestCoprocessorEndpoint.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131128#comment-13131128 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2683
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/2029/#comment6060>
It's a bit complicated; to get the coprocessors for a particular regionserver R, you do:
1. HBaseAdmin object.getClusterStatus() => ClusterStatus object
2. ClusterStatus object.getServerInfo() => set<HServerLoad>
3. Find R amongst the set returned in step 2 (actually ClusterStatus stores the servers as a map keyed on the server name, so if you know the server's name, you don't need to iterate through the set).
3. HServerLoad object.getCoprocessors() => String[].
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/2029/#comment6061>
We could, but RSStatusTmpl doesn't use HBaseAdmin, but rather HRegionServer as the source of all of the information that it displays.
- Eugene
On 2011-10-16 16:22:16, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-16 16:22:16)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 7d2f82e
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java e2e694a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() added to (existing) src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127812#comment-13127812 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-10-14 19:57:11.628623)
Review request for hbase and Mingjie Lai.
Changes
-------
removed temp files from last diff; please excuse the clutter.
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 7d2f82e
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java e2e694a
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119698#comment-13119698 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-10-03 22:32:46.964479)
Review request for hbase and Mingjie Lai.
Changes
-------
use String[] as the return type to report loaded coprocessors.
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs (updated)
-----
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated HBASE-4070:
---------------------------------
Attachment: HBASE-4070.patch
Identical to https://reviews.apache.org/r/2029/diff/5/
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127946#comment-13127946 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-10-14 22:45:37.744775)
Review request for hbase and Mingjie Lai.
Changes
-------
whitespace changes: keep lines 80 characters or less.
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs (updated)
-----
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 7d2f82e
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java e2e694a
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135123#comment-13135123 ]
Hudson commented on HBASE-4070:
-------------------------------
Integrated in HBase-0.92 #79 (See [https://builds.apache.org/job/HBase-0.92/79/])
HBASE-4070 Improve region server metrics to report loaded coprocessors to master
apurtell :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon
* /hbase/branches/0.92/src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HServerLoad.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117700#comment-13117700 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 505
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46417#file46417line505>
bq. >
bq. > getSimpleName() only returns the class name w/o package info. I think we should use the whole class name for the comparator.
Full classnames are canonical and avoid accidental conflict, but are unwieldy and not so nice to look at. Judgement call, I'd say. I think it unlikely that for any given deployment two coprocessors will have the same class name but be in a different package.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2183
-----------------------------------------------------------
On 2011-09-29 20:15:12, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 20:15:12)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java a069400
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 270f3f3
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/main/ruby/hbase/admin.rb b244ffe
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java a8f2a9c
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() added to src/test/java/o.a.h.h/coprocessor/TestCoprocessorEndpoint.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117884#comment-13117884 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-09-30 04:58:20.313786)
Review request for hbase and Mingjie Lai.
Changes
-------
serialize/deserialize masterCoprocessors String value in ClusterStatus. Needed by HBase clients (e.g. for HBASE-3512).
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs (updated)
-----
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113049#comment-13113049 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
Review request for hbase and Mingjie Lai.
Summary
-------
Proposed fix for HBASE-4070. Relies on functionality provided by HBASE-4014.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs
-----
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java bff1f6c
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java a8f2a9c
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
One new test : testServerManagerCoprocessorReport, added to src/test/java/o.a.h.h/coprocessor/TestCoprocessorEndpoint.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121507#comment-13121507 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-10-05 21:40:25.842211)
Review request for hbase and Mingjie Lai.
Changes
-------
Addressed Michael Stack's review (thanks St^Ack).
-in HServerLoad, clarify purpose of data member "coprocessors" versus "getCoprocessors()" method.
-remove unneeded String Comparator.
-moved tests to TestClassLoading.java (thanks to Mingjie Lai for the suggestion)
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs (updated)
-----
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117574#comment-13117574 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-09-29 19:56:54.298361)
Review request for hbase and Mingjie Lai.
Changes
-------
Updated patch that shows both master as well as regionserver loaded coprocessors. Master UI shows both master and regionserver coprocessor information, while regionserver UI (/rs-status) shows regionserver coprocessor information. See JIRA for screenshots.
Summary
-------
Proposed fix for HBASE-4070. Relies on functionality provided by HBASE-4014.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs (updated)
-----
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java a069400
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 270f3f3
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
src/main/ruby/hbase/admin.rb b244ffe
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java a8f2a9c
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
One new test : testServerManagerCoprocessorReport, added to src/test/java/o.a.h.h/coprocessor/TestCoprocessorEndpoint.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135005#comment-13135005 ]
Hudson commented on HBASE-4070:
-------------------------------
Integrated in HBase-TRUNK #2366 (See [https://builds.apache.org/job/HBase-TRUNK/2366/])
HBASE-4070 Improve region server metrics to report loaded coprocessors to master
apurtell :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon
* /hbase/trunk/src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HServerLoad.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated HBASE-4070:
---------------------------------
Attachment: HBASE-4070.patch
Display both master as well as regionserver coprocessors in master Web UI.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118220#comment-13118220 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
bq. On 2011-09-29 21:52:40, Andrew Purtell wrote:
bq. >
bq.
bq. Andrew Purtell wrote:
bq. Actually, I do have a comment. Do we need a method in HMasterInterface for getting the coprocessor set? Can't it be extracted from HSL?
bq.
bq. Andrew Purtell wrote:
bq. I meant via ClusterStatus, therefore via HBaseAdmin.getClusterStatus().
bq.
bq. Eugene Koontz wrote:
bq. Removed HMasterInterface change since we don't need it.
bq.
bq. ClusterStatus constructor has an additional param that is the string representation of the Master's loaded coprocessor set.
bq.
bq. HBaseAdmin can now use getClusterStatus() to get Master's coprocessor set. HBASE-3512's patch will be updated to use this to show master coprocessors in the shell.
Cool, thanks Eugene
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2179
-----------------------------------------------------------
On 2011-09-30 04:58:20, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-30 04:58:20)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz reassigned HBASE-4070:
------------------------------------
Assignee: Eugene Koontz
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated HBASE-4070:
---------------------------------
Attachment: master-web-ui.jpg
HBase Master Web UI, showing master and regionserver coprocessors.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121511#comment-13121511 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-10-05 21:45:30.186260)
Review request for hbase and Mingjie Lai.
Changes
-------
add missing </tr> in RSStatusTmpl.jamon.
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs (updated)
-----
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117694#comment-13117694 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2183
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5082>
an extra indent?
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5083>
Just a naming suggestion for walCoprocessors=>coprocessors. Although right now WALObserver is the only RS level CP, but it'd better not to indicate here.
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5085>
getSimpleName() only returns the class name w/o package info. I think we should use the whole class name for the comparator.
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/2029/#comment5092>
do we really need to provide it thru HTAdmin? if we do, the returned value is not correct in case of exception.
src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
<https://reviews.apache.org/r/2029/#comment5087>
The new method is a little odd. how about just getCoprocessors().
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<https://reviews.apache.org/r/2029/#comment5091>
still the method name?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/2029/#comment5096>
same as HMasterInterface. can we just generateCoprocessorString() => String getCoprocessors()?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/2029/#comment5097>
is it okay just reuse the existing serverLoad, without rebuilding the whole thing?
this.serverInfo.getLoad()
but it may not be a big issue.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
<https://reviews.apache.org/r/2029/#comment5098>
The file TestCoprocessorEndpoint is particularly for testing cp endpoint. It's odd to put the new test cases to this file. Maybe TestClassLoading is a better place.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
<https://reviews.apache.org/r/2029/#comment5100>
according the previous override comparator in HRL, the cps should be in alphabet order. so you don't need to compare this 2 strings.
- Mingjie
On 2011-09-29 20:15:12, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 20:15:12)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java a069400
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 270f3f3
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/main/ruby/hbase/admin.rb b244ffe
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java a8f2a9c
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() added to src/test/java/o.a.h.h/coprocessor/TestCoprocessorEndpoint.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118218#comment-13118218 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
bq. On 2011-09-29 21:52:40, Andrew Purtell wrote:
bq. >
bq.
bq. Andrew Purtell wrote:
bq. Actually, I do have a comment. Do we need a method in HMasterInterface for getting the coprocessor set? Can't it be extracted from HSL?
bq.
bq. Andrew Purtell wrote:
bq. I meant via ClusterStatus, therefore via HBaseAdmin.getClusterStatus().
Removed HMasterInterface change since we don't need it.
ClusterStatus constructor has an additional param that is the string representation of the Master's loaded coprocessor set.
HBaseAdmin can now use getClusterStatus() to get Master's coprocessor set. HBASE-3512's patch will be updated to use this to show master coprocessors in the shell.
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2179
-----------------------------------------------------------
On 2011-09-30 04:58:20, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-30 04:58:20)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Andrew Purtell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-4070:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
0.92.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk and 0.92
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117583#comment-13117583 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-09-29 20:15:12.832998)
Review request for hbase and Mingjie Lai.
Changes
-------
show both tests.
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs
-----
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java a069400
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 270f3f3
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
src/main/ruby/hbase/admin.rb b244ffe
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java a8f2a9c
Diff: https://reviews.apache.org/r/2029/diff
Testing (updated)
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() added to src/test/java/o.a.h.h/coprocessor/TestCoprocessorEndpoint.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117656#comment-13117656 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
bq. On 2011-09-29 21:52:40, Andrew Purtell wrote:
bq. >
bq.
bq. Andrew Purtell wrote:
bq. Actually, I do have a comment. Do we need a method in HMasterInterface for getting the coprocessor set? Can't it be extracted from HSL?
I meant via ClusterStatus, therefore via HBaseAdmin.getClusterStatus().
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2179
-----------------------------------------------------------
On 2011-09-29 20:15:12, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 20:15:12)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java a069400
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 270f3f3
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/main/ruby/hbase/admin.rb b244ffe
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java a8f2a9c
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() added to src/test/java/o.a.h.h/coprocessor/TestCoprocessorEndpoint.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127807#comment-13127807 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-10-14 19:50:47.677043)
Review request for hbase and Mingjie Lai.
Changes
-------
Addresses Mingjie's review:
-use Arrays.equals() where appropriate (as opposed to String[].equals() which was incorrect).
-check for Arrays.toString()'s returning null in HServerLoad.toString().
-add more testing in TestClassLoading.java for coprocessor load-reporting as it varies according to user tables loading and unloading.
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs (updated)
-----
.gitignore a8a9adc
conf/hbase-site.xml af4c300
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 7d2f82e
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java e2e694a
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128436#comment-13128436 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-10-16 16:22:16.729481)
Review request for hbase and Mingjie Lai.
Changes
-------
Updated 'testing done' section.
Summary
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs
-----
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 7d2f82e
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java e2e694a
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
Diff: https://reviews.apache.org/r/2029/diff
Testing (updated)
-------
Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() added to (existing) src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117646#comment-13117646 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2179
-----------------------------------------------------------
Ship it!
- Andrew
On 2011-09-29 20:15:12, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 20:15:12)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java a069400
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 270f3f3
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/main/ruby/hbase/admin.rb b244ffe
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java a8f2a9c
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() added to src/test/java/o.a.h.h/coprocessor/TestCoprocessorEndpoint.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118217#comment-13118217 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, line 3245
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46422#file46422line3245>
bq. >
bq. > is it okay just reuse the existing serverLoad, without rebuilding the whole thing?
bq. >
bq. > this.serverInfo.getLoad()
bq. >
bq. > but it may not be a big issue.
sorry, I don't see a serverInfo member in HRegionServer..?
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 190
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46417#file46417line190>
bq. >
bq. > an extra indent?
fixed; thanks.
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 465
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46417#file46417line465>
bq. >
bq. > Just a naming suggestion for walCoprocessors=>coprocessors. Although right now WALObserver is the only RS level CP, but it'd better not to indicate here.
I changed the parameter name to "rsCoprocessors" and added a javadoc @param note; what do you think? Could also just call it "coprocessors" as you suggested.
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 505
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46417#file46417line505>
bq. >
bq. > getSimpleName() only returns the class name w/o package info. I think we should use the whole class name for the comparator.
bq.
bq. Andrew Purtell wrote:
bq. Full classnames are canonical and avoid accidental conflict, but are unwieldy and not so nice to look at. Judgement call, I'd say. I think it unlikely that for any given deployment two coprocessors will have the same class name but be in a different package.
I would agree with Andrew and use getSimpleName().
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java, line 261
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46420#file46420line261>
bq. >
bq. > The new method is a little odd. how about just getCoprocessors().
Removed HMasterInterface.java changes at Andy's recommendation: now no difference with trunk.
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 1514
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46421#file46421line1514>
bq. >
bq. > still the method name?
changed to getCoprocessors() at Andy's recommendation.
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, line 3244
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46422#file46422line3244>
bq. >
bq. > same as HMasterInterface. can we just generateCoprocessorString() => String getCoprocessors()?
changed; thanks.
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java, line 1652
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46418#file46418line1652>
bq. >
bq. > do we really need to provide it thru HTAdmin? if we do, the returned value is not correct in case of exception.
removed differences from trunk; you are right: we don't need it here.
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java, line 24
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46424#file46424line24>
bq. >
bq. > The file TestCoprocessorEndpoint is particularly for testing cp endpoint. It's odd to put the new test cases to this file. Maybe TestClassLoading is a better place.
Good idea; moved to a new source file: TestCoprocessorReporting.java.
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java, line 201
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46424#file46424line201>
bq. >
bq. > according the previous override comparator in HRL, the cps should be in alphabet order. so you don't need to compare this 2 strings.
Thanks; removed extra string and added comment with your point.
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2183
-----------------------------------------------------------
On 2011-09-30 04:58:20, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-30 04:58:20)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117581#comment-13117581 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------
(Updated 2011-09-29 20:13:32.064908)
Review request for hbase and Mingjie Lai.
Changes
-------
Remove "relies on HBASE-4014": this is no longer true.
Summary (updated)
-------
Proposed fix for HBASE-4070.
This addresses bug HBASE-4070.
https://issues.apache.org/jira/browse/HBASE-4070
Diffs
-----
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java a069400
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 270f3f3
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
src/main/ruby/hbase/admin.rb b244ffe
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java a8f2a9c
Diff: https://reviews.apache.org/r/2029/diff
Testing
-------
One new test : testServerManagerCoprocessorReport, added to src/test/java/o.a.h.h/coprocessor/TestCoprocessorEndpoint.java.
Thanks,
Eugene
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131044#comment-13131044 ]
Ted Yu commented on HBASE-4070:
-------------------------------
w.r.t. the comment on using HServerInfo rather than HServerLoad to pass coprocessor information:
HServerInfo is deprecated.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121441#comment-13121441 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2352
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5427>
You are right; thanks. No stringComparator needed.
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5426>
I think there's a need for a data member here because HServerLoad needs an initial set of regionserver-level coprocessors supplied to it when it is constructed (this is the last parameter "final Set<String> coprocessors" that we have added to the HServerLoad constructor).
Then, when getCoprocessors() is called, we take the union of those regionserver-level coprocessors with all of the currently-loaded region-level coprocessors.
I am creating a local returnValue that holds this set union, in getCoprocessors(), to make this more clear hopefully, and adding documentation to that effect.
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
<https://reviews.apache.org/r/2029/#comment5425>
Removed stringComparator since it's not needed for TreeSet<String> - thanks.
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<https://reviews.apache.org/r/2029/#comment5423>
Good point, thank you.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/2029/#comment5420>
Thanks, good idea.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java
<https://reviews.apache.org/r/2029/#comment5412>
Mingjie recommends moving to TestClassLoading.java - sounds good to me.
- Eugene
On 2011-10-04 01:21:46, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-04 01:21:46)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated HBASE-4070:
---------------------------------
Attachment: HBASE-4070.patch
Display both master as well as regionserver coprocessors in master Web UI.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118221#comment-13118221 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
bq. On 2011-09-29 22:42:26, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 465
bq. > <https://reviews.apache.org/r/2029/diff/2/?file=46417#file46417line465>
bq. >
bq. > Just a naming suggestion for walCoprocessors=>coprocessors. Although right now WALObserver is the only RS level CP, but it'd better not to indicate here.
bq.
bq. Eugene Koontz wrote:
bq. I changed the parameter name to "rsCoprocessors" and added a javadoc @param note; what do you think? Could also just call it "coprocessors" as you suggested.
If the coprocessor list is within a regionserver load report, it's implicitly about the regionserver so no "rs" prefix is needed on the member, no? Seems cleaner not to use one.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2183
-----------------------------------------------------------
On 2011-09-30 04:58:20, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-30 04:58:20)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131025#comment-13131025 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2678
-----------------------------------------------------------
+1 on patch. Just an ontological question.
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment6041>
Is this a 'load'? Or is this an attribute of the server? We used to have an HServerInfo. This looks like something that would belong in there rather than in HSL?
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/2029/#comment6043>
Should we be able to ask a regionserver what CPs it has loaded from HBaseAdmin (Maybe its already in here)?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/2029/#comment6044>
Can we get here from HBaseAdmin
- Michael
On 2011-10-16 16:22:16, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-16 16:22:16)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 7d2f82e
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java e2e694a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() added to (existing) src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "Mingjie Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108000#comment-13108000 ]
Mingjie Lai commented on HBASE-4070:
------------------------------------
@stack Let me start to work on it and put a patch this week.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated HBASE-4070:
---------------------------------
Attachment: HBASE-4070.patch
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated HBASE-4070:
---------------------------------
Status: Patch Available (was: Open)
This patch requires HBASE-4014 (as noted in "Issue Links")
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119762#comment-13119762 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2295
-----------------------------------------------------------
Getting close Eugene. Suggest a cleaner naming of some methods. Also question if passing in a set of coprocessor environments is necessary when a set or array of String can be built just as easily before calling the HSL constructor.
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
<https://reviews.apache.org/r/2029/#comment5280>
masterCoprocessors
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
<https://reviews.apache.org/r/2029/#comment5281>
Likewise
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
<https://reviews.apache.org/r/2029/#comment5284>
getMasterCoprocessors()
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5285>
Why do you need this if you have the set of coprocessor environments?
Turn the question around, why do you need the coprocessor environments if you have this set of strings? Build this set and pass it to the HSL constructor.
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5286>
getCoprocessors()
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5287>
See above
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5288>
See above. Construct the set of strings or an array of strings and pass it in.
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5289>
getCoprocessors()
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5290>
See above
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/2029/#comment5291>
getMasterCoprocessors()
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<https://reviews.apache.org/r/2029/#comment5292>
getCoprocessors()
- Andrew
On 2011-10-03 22:32:46, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-03 22:32:46)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107504#comment-13107504 ]
stack commented on HBASE-4070:
------------------------------
@Mingjie Any movement on this? Its blocking 3512 filed against 0.92.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120557#comment-13120557 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2327
-----------------------------------------------------------
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon
<https://reviews.apache.org/r/2029/#comment5374>
Nice
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5375>
Is this comparator needed? Without it I'd think we'd sort by the String's "natural order" which is probably what we want?
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5376>
Are we doing this twice here? There is a getProcessors and its makes them up on the fly. Do we need this data member?
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
<https://reviews.apache.org/r/2029/#comment5377>
We don't use a Comparator here.
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<https://reviews.apache.org/r/2029/#comment5379>
Could you just do masterCoprocessors.toArray here?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/2029/#comment5381>
Or do
return hsl == null? null: hsl.getCoprocessors();
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java
<https://reviews.apache.org/r/2029/#comment5386>
Can these asserts be done inside another CP test rather than in a standalone test as here? These cluster spinups take time. No biggie if not possible.
- Michael
On 2011-10-04 01:21:46, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-04 01:21:46)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134734#comment-13134734 ]
stack commented on HBASE-4070:
------------------------------
Here was my last comment on the patch over on RB in response to Eugene's "Hi Michael, As Ted mentioned, HServerInfo is deprecated (per https://issues.apache.org/jira/browse/HBASE-1502)":
{code}
Michael Stack 5 days, 4 hours ago (October 19th, 2011, 11:34 p.m.)
Yes but that is not reason to shoe horn it in elsewhere (smile).
There is another server attribute that is currently without a home (webuiport) and I think there are other a bunch of server attrbutes -- as opposed to server load -- that servers might export and have aggregated over in the master and/or used calculating cluster balance and the like.
We could let this patch go in as is or we could build the server attributes mechanism -- ServerInfoV2 or json in regionserver znode, etc. -- and put stuff like this in there.
{code}
I think it a little perverse passing loaded coprocessors as part of HServerLoad. I opened HBASE-4660 to address it.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated HBASE-4070:
---------------------------------
Attachment: HBASE-4070.patch
same as https://reviews.apache.org/r/2029/diff/11/
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120671#comment-13120671 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2336
-----------------------------------------------------------
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon
<https://reviews.apache.org/r/2029/#comment5398>
missing </tr>
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java
<https://reviews.apache.org/r/2029/#comment5397>
should be getCoprocessors()
- Eugene
On 2011-10-04 01:21:46, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-04 01:21:46)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated HBASE-4070:
---------------------------------
Attachment: rs-status-web-ui.jpg
Regionserver Web UI, showing loaded coprocessors.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4070) [Coprocessors] Improve region server
metrics to report loaded coprocessors to master
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated HBASE-4070:
---------------------------------
Attachment: (was: HBASE-4070.patch)
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region
server metrics to report loaded coprocessors to master
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123354#comment-13123354 ]
jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2396
-----------------------------------------------------------
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
<https://reviews.apache.org/r/2029/#comment5499>
Add comment like "these three declarations are only used by testRegionServerCoprocessorsReported"
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
<https://reviews.apache.org/r/2029/#comment5500>
Add comment "this declaration is only used by testMasterCoprocessorsReported".
- Eugene
On 2011-10-05 21:45:30, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-05 21:45:30)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira