You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jan Høydahl (JIRA)" <ji...@apache.org> on 2016/07/13 20:30:21 UTC
[jira] [Commented] (SOLR-9237)
DefaultSolrHighlighter.doHighlightingByFastVectorHighlighter can't be
overidden
[ https://issues.apache.org/jira/browse/SOLR-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375686#comment-15375686 ]
Jan Høydahl commented on SOLR-9237:
-----------------------------------
Have you validated that this is the only necessary change?
> DefaultSolrHighlighter.doHighlightingByFastVectorHighlighter can't be overidden
> -------------------------------------------------------------------------------
>
> Key: SOLR-9237
> URL: https://issues.apache.org/jira/browse/SOLR-9237
> Project: Solr
> Issue Type: Bug
> Components: highlighter
> Affects Versions: 6.1
> Reporter: Gethin James
> Assignee: Jan Høydahl
> Fix For: 6.2, master (7.0)
>
> Attachments: SOLR-9237.patch
>
>
> With *6.1.0* the *protected* method DefaultSolrHighlighter.doHighlightingByFastVectorHighlighter passes in a *private* class called FvhContainer which makes it very difficult to extend.
> I have code that extends DefaultSolrHighlighter which I can't fix due to this issue.
> Could you consider making FvhContainer "protected" and use a constructor?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org