You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/01/06 00:24:08 UTC

Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[7/9] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs
-----

  src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Feb. 9, 2015, 9:38 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[6/9] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
  src/examples/test_isolator_module.cpp 3b92b04e90ee7c2214597ed18c9b9270329ab545 
  src/module/isolator.hpp b5c86e38616a5e9068f06131094f473d933429a8 
  src/slave/containerizer/mesos/containerizer.cpp fa40d47aee7803833bcde6cce1e86a21d7cf27d0 
  src/tests/isolator_tests.cpp 093b9fd97c28efc008e790346f4cffa7a05ca275 
  src/tests/module_tests.cpp 2e113be2a48290fb862b04022f38458b4612ab26 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Feb. 4, 2015, 10:16 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[6/9] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Feb. 2, 2015, 4:08 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[6/9] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 27, 2015, 6:51 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description (updated)
-------

[6/9] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 10:18 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description (updated)
-------

[7/10] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 9:38 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[8/10] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 8:50 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[8/10] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 8:18 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[8/10] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/#review68824
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On Jan. 19, 2015, 2:52 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29604/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 2:52 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [8/10] Build Mesos Modules outside Mesos source tree.
> 
> The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
>   src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
>   src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
>   src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 
>   src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
>   src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 
> 
> Diff: https://reviews.apache.org/r/29604/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 19, 2015, 5:52 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

Rebased diff.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[8/10] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 11:43 a.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[8/10] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp 0bcf5ce7cfab470cabd3af3535344d19cb33b1c8 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/#review67733
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Jan. 10, 2015, 7:43 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29604/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2015, 7:43 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [8/10] Build Mesos Modules outside Mesos source tree.
> 
> The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 
>   src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
>   src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
>   src/slave/containerizer/mesos/containerizer.cpp 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 
>   src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
>   src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 
> 
> Diff: https://reviews.apache.org/r/29604/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 10, 2015, 2:43 a.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[8/10] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 6:39 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

Updated diff for compilation fix.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[8/10] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 6:06 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased diff.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description (updated)
-------

[8/10] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs (updated)
-----

  src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 6, 2015, 5:39 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[7/9] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs
-----

  src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
-----------------------------------------------------------

(Updated Jan. 5, 2015, 6:27 p.m.)


Review request for mesos, Niklas Nielsen and Till Toenshoff.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[7/9] Build Mesos Modules outside Mesos source tree.

The isolation module can thus include <mesos/module/isolator.hpp> to get all required definitions.


Diffs
-----

  src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 
  src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c 
  src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 
  src/slave/containerizer/mesos/containerizer.cpp 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 
  src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 
  src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc 

Diff: https://reviews.apache.org/r/29604/diff/


Testing
-------

make check


Thanks,

Kapil Arya