You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:06:40 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #14164: ARROW-17769: [Java] Upgrade adapter/ to Junit 5

lidavidm commented on code in PR #14164:
URL: https://github.com/apache/arrow/pull/14164#discussion_r985921938


##########
java/adapter/avro/src/test/java/org/apache/arrow/AvroTestBase.java:
##########
@@ -70,7 +78,7 @@ protected Schema getSchema(String schemaName) throws Exception {
   }
 
   protected VectorSchemaRoot writeAndRead(Schema schema, List data) throws Exception {
-    File dataFile = TMP.newFile();
+    File dataFile = tmp.resolve("data").toFile();

Review Comment:
   Maybe this could be updated to use in-memory streams instead of file streams? Then we could get rid of the filesystem dependency entirely



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org