You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/10/20 02:21:15 UTC

svn commit: r1765739 [2/2] - in /poi/trunk/src: integrationtest/org/apache/poi/stress/ ooxml/testcases/org/apache/poi/xssf/model/ ooxml/testcases/org/apache/poi/xssf/usermodel/charts/ scratchpad/testcases/org/apache/poi/hdgf/streams/ scratchpad/testcas...

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestRawDataBlock.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestRawDataBlock.java?rev=1765739&r1=1765738&r2=1765739&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestRawDataBlock.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestRawDataBlock.java Thu Oct 20 02:21:14 2016
@@ -190,9 +190,9 @@ public final class TestRawDataBlock exte
 	 *  not to have any data
 	 */
 	public static class SlowInputStream extends InputStream {
-		private Random rnd = new Random();
-		private byte[] data;
-		private int chunkSize;
+		private final Random rnd = new Random();
+		private final byte[] data;
+		private final int chunkSize;
 		private int pos = 0;
 
 		public SlowInputStream(byte[] data, int chunkSize) {

Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/TestEvaluationCache.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/TestEvaluationCache.java?rev=1765739&r1=1765738&r2=1765739&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/formula/TestEvaluationCache.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/formula/TestEvaluationCache.java Thu Oct 20 02:21:14 2016
@@ -91,8 +91,8 @@ public class TestEvaluationCache extends
 
 		private final List<String> _logList;
 		private final HSSFWorkbook _book;
-		private Map<ICacheEntry,EvaluationCell> _formulaCellsByCacheEntry;
-		private Map<ICacheEntry,Loc> _plainCellLocsByCacheEntry;
+		private final Map<ICacheEntry,EvaluationCell> _formulaCellsByCacheEntry;
+		private final Map<ICacheEntry,Loc> _plainCellLocsByCacheEntry;
 
 		public EvalListener(HSSFWorkbook wb) {
 			_book = wb;

Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetHiding.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetHiding.java?rev=1765739&r1=1765738&r2=1765739&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetHiding.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetHiding.java Thu Oct 20 02:21:14 2016
@@ -35,7 +35,7 @@ public abstract class BaseTestSheetHidin
     protected Workbook wbH;
     protected Workbook wbU;
 
-    private String _file1, _file2;
+    private final String _file1, _file2;
 
     /**
 	 * @param testDataProvider an object that provides test data in HSSF /  specific way

Modified: poi/trunk/src/testcases/org/apache/poi/ss/util/cellwalk/TestCellWalk.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/util/cellwalk/TestCellWalk.java?rev=1765739&r1=1765738&r2=1765739&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/util/cellwalk/TestCellWalk.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/util/cellwalk/TestCellWalk.java Thu Oct 20 02:21:14 2016
@@ -35,7 +35,7 @@ public class TestCellWalk extends TestCa
 	{null,       null, "str"}
     };
 
-    private CountCellHandler countCellHandler = new CountCellHandler();
+    private final CountCellHandler countCellHandler = new CountCellHandler();
 
     public void testNotTraverseEmptyCells() {
 	Workbook wb = new HSSFWorkbook();



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org