[GitHub] [hive] cnauroth commented on a diff in pull request #3817: HIVE-26794: Explore changing TxnHandler#connPoolMutex to NoPoolConnectionPool

[GitBox <gi...@apache.org>]

cnauroth commented on code in PR #3817:
URL: https://github.com/apache/hive/pull/3817#discussion_r1037524628


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -375,8 +375,13 @@ public void setConf(Configuration conf){
           connPool = setupJdbcConnectionPool(conf, maxPoolSize);
         }
         if (connPoolMutex == null) {
-          configurator.resetName("mutex");
-          connPoolMutex = setupJdbcConnectionPool(conf, maxPoolSize);
+          // It's kind of a waste to create a fixed size connection pool as same as the connPool and
+          // the connection pool used in ObjectStore, and the connection pool is mostly used for MutexAPI that
+          // is primarily designed to provide coarse-grained mutex support to maintenance tasks running inside
+          // the Metastore, we only use getConnection method to retrieve connection from this pool,
+          // changing it to NoPoolConnectionPool will make Metastore more scalable especially
+          // there is a leader in the warehouse.

Review Comment:
   Is there a missing word here, e.g. "...especially **if** there is a leader..."?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org