[Bug 55938] clang-analyzer report for 1.1.29

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=55938

--- Comment #1 from Christopher Schultz <ch...@christopherschultz.net> ---
Some comments about the report:

1. The 2 "null dereference" items are from functions  that AFAICT are never
used (jbs_new and jbs_read). Normally the code identified by the compiler here
would be considered a big problem (they are obvious logic errors) but it's not
really a big deal given the fact that these functions are not used.

2. The dead assignments should probably be investigated. I didn't look at all
of them, but for example, network.c:722 has an obvious logic error in that
GetByteArrayElements gets called twice under certain circumstances when a
single call appears to be appropriate.

3. The 'nonnull' arguments should also b e investigated.

I suspect a lot of the cruft found by the compiler, here, can be completely
removed from the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org