[jira] [Commented] (HBASE-13982) Add info for visibility labels/cell TTLs to ImportTsv

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991057#comment-14991057 ] 

Hadoop QA commented on HBASE-13982:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12770723/HBASE-13982.patch
  against master branch at commit 21b607e322df0404c9941bc3dd12faef6b7957fe.
  ATTACHMENT ID: 12770723

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1729 checkstyle errors (more than the master's current 1726 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +      "Other special columns that can be specified are " + TsvParser.CELL_TTL_COLUMN_SPEC + " and " + TsvParser.CELL_VISIBILITY_COLUMN_SPEC + "." +
+      TsvParser.CELL_TTL_COLUMN_SPEC +" designates that this column will be used as a Cell's Time To Live (TTL) attribute. " +
+      TsvParser.CELL_VISIBILITY_COLUMN_SPEC + " designates that this column contains the visibility label expression." +

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

      {color:red}-1 core zombie tests{color}.  There are possible 5 zombie test(s): 	at org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager.test(TestReplicationWALReaderManager.java:190)
	at org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint.testRegionReplicaReplicationIgnoresDisabledTables(TestRegionReplicaReplicationEndpoint.java:399)
	at org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint.testRegionReplicaReplicationIgnoresDisabledTables(TestRegionReplicaReplicationEndpoint.java:331)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16395//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16395//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16395//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16395//console

This message is automatically generated.

> Add info for visibility labels/cell TTLs to ImportTsv
> -----------------------------------------------------
>
>                 Key: HBASE-13982
>                 URL: https://issues.apache.org/jira/browse/HBASE-13982
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 1.1.0.1
>            Reporter: Lars George
>            Assignee: NIDHI GAMBHIR
>              Labels: beginner
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-13982.patch
>
>
> HBASE-9832 added support for two more optional, special TSV columns, but no usage info was added. Add.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)