You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by abhishekagarwal87 <gi...@git.apache.org> on 2016/06/10 13:21:13 UTC

[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java

Github user abhishekagarwal87 commented on the issue:

    https://github.com/apache/storm/pull/1445
  
    Hi @unsleepy22 . Going through the code, I still think sendUnanchored and sendToEventsLogger should be moved to superclass. ackSpoutMsg/failSpoutMsg should move to SpoutExecutor class. 
    
    ExecutorData can be merged with BaseExecutor class since executor data is common to both spout and bolt. Once that happens, executor object can be passed around e.g. 
    ```
    public SpoutOutputCollectorImpl(ISpout spout, SpoutExecutor executorData....
    ```
    Other than that, translation looks good (done with first pass). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---