You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/04/19 22:46:54 UTC
[Bug 4268] New: remove $Id: lines
http://bugzilla.spamassassin.org/show_bug.cgi?id=4268
Summary: remove $Id: lines
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: All
OS/Version: other
Status: NEW
Severity: normal
Priority: P3
Component: spamassassin
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jgmyers@proofpoint.com
A couple of the SpamAssassin modules have comments with $Id: lines. These lines
serve no purpose other than to cause problems with CVS.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4268] remove $Id: lines
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4268
quinlan@pathname.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From quinlan@pathname.com 2005-04-29 01:39 -------
removed the lines
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4268] remove $Id: lines
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4268
------- Additional Comments From felicity@kluge.net 2005-04-19 13:52 -------
Subject: Re: New: remove $Id: lines
On Tue, Apr 19, 2005 at 01:46:54PM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> A couple of the SpamAssassin modules have comments with $Id: lines. These lines
> serve no purpose other than to cause problems with CVS.
Hrm. I'd actually like to set the property so that Id gets updated with SVN
revision. I agree the current $Id$ tags are useless since they're not updated
via SVN.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4268] remove $Id: lines
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4268
------- Additional Comments From ajs@ajs.com 2005-04-19 18:01 -------
Of course, the cvs folks have the option of using the -ko option to avoid
keyword expansion (which you should ALWAYS do when dealing with source which
your CVS repository is not authoritative for).
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4268] remove $Id: lines
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4268
------- Additional Comments From jgmyers@proofpoint.com 2005-04-19 14:40 -------
The automated $Id: information is clearly not being missed. There is no clear
reason why it is on those particular five files.
The $Id: lines cause problems for people who put these files into their own CVS
repositories.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4268] remove $Id: lines
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4268
------- Additional Comments From quinlan@pathname.com 2005-04-20 01:30 -------
Subject: Re: remove $Id: lines
I agree. Let's drop them.
Note: a few SVN expansion (mostly $Rev) lines like the one in
70_testing.cf *are* needed.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4268] remove $Id: lines
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4268
------- Additional Comments From jgmyers@proofpoint.com 2005-04-19 13:47 -------
Created an attachment (id=2796)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2796&action=view)
Proposed fix
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4268] remove $Id: lines
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4268
------- Additional Comments From automasschecker@jmason.org 2005-04-19 15:46 -------
Subject: Re: remove $Id: lines
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
to be honest, I agree -- for comments at least. I've never used them,
I've never found them useful, but I *have* found them causing patch
rejections when a patch contains diffs between different revisions where
they've been updated.
in other words the only time I've ever noticed them is when they've caused
trouble. let's drop 'em...
- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Exmh CVS
iD8DBQFCZYndMJF5cimLx9ARAo8kAKCJIuhlgV0CbpP1brjJab8I4rmpugCeOCe3
z4a0mMhGE10b7rxXXj/2r3E=
=r7Mh
-----END PGP SIGNATURE-----
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.