You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/02 07:03:47 UTC

[GitHub] [apisix] spacewander commented on issue #2924: [Proposal] Support both empty array and field-omitted for fields like remote_addrs

spacewander commented on issue #2924:
URL: https://github.com/apache/apisix/issues/2924#issuecomment-737037777


   Put my disagreement here:
   https://github.com/apache/apisix-dashboard/pull/948#discussion_r533932864
   
   Yes, but the backends care. This change just shift the duty to the backend.
   There are three problems:
   1. We have two backends. It is hard to sync the validation. In the future, we may have other backends like envoy, should we do the same again?
   2. jsonschema treat `empty array` and `omit array field` different. We have to write code manually twice.
   3. What if one day we want to distinguish `[]` from `nil`?
   
   In short, type matters. If `[]` and `nil` are two different types, we should distinguish them from the source.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org