You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/22 19:51:08 UTC

[GitHub] zheng-da commented on a change in pull request #12502: [NGRAPH] MXNet - nGraph initial integration

zheng-da commented on a change in pull request #12502: [NGRAPH] MXNet - nGraph initial integration
URL: https://github.com/apache/incubator-mxnet/pull/12502#discussion_r227064861
 
 

 ##########
 File path: src/ndarray/ndarray.cc
 ##########
 @@ -733,6 +739,21 @@ void NDArray::UpdateMKLDNNMemDesc() {
 }
 #endif
 
+#if MXNET_USE_NGRAPH == 1
+std::shared_ptr<ngraph::runtime::TensorView> &NDArray::create_tensor_view() {
 
 Review comment:
   why do you return a reference of a shared pointer?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services