You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/05/12 00:59:01 UTC
[Bug 119337] New: xlsx import with chart is not displayed
https://issues.apache.org/ooo/show_bug.cgi?id=119337
Priority: P3
Bug ID: 119337
Assignee: ooo-issues@incubator.apache.org
Summary: xlsx import with chart is not displayed
Severity: blocker
Issue Type: DEFECT
Classification: Application
OS: Mac OS X
Reporter: matthew@mcgillis.org
Hardware: Macintosh
Status: UNCONFIRMED
Version: recent-trunk
Component: open-import
Product: spreadsheet
Created attachment 77531
--> https://issues.apache.org/ooo/attachment.cgi?id=77531&action=edit
Example xlsx file with chart.
Opening the attached xlsx file in Apache OpenOffice 3.4.0 on Mac OS X does not
display the chart. You just get a box with "OLE" Icon inside it.
I have also attached a screen capture which compares what is seen in excel vs
open office. The chart is properly display in OpenOffice 3.3.0.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #1 from matthew@mcgillis.org ---
Created attachment 77532
--> https://issues.apache.org/ooo/attachment.cgi?id=77532&action=edit
PNG of what is shown in OpenOffice vs Excel
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #13 from Armin Le Grand <Ar...@me.com> ---
ALG: SvxOle2Shape is derived from SvxShapeText, that is derived from two
classes, SvxShape and SvxUnoTextBase. Mac calls getPropertyValue at the 2nd
while Win uses the first. Looks like a compiler decision problem...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #3 from zhao xia <do...@hotmail.com> ---
Which build you are using? I can't reproduce it on Mac platform as well.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #6 from Andre <af...@a-w-f.de> ---
Tried different versions:
It is OK on OOo 3.3 and 3.4 beta. It is broken on AOO 3.4.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |AOO 3.4.1
--- Comment #26 from jsc@apache.org ---
set target milestone AOO 3.4.1
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #23 from Armin Le Grand <Ar...@me.com> ---
ALG: Merged change to AOO34 branch for 3.4.1 version as r1353458
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
zhao xia <do...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |doudou1976@hotmail.com
--- Comment #2 from zhao xia <do...@hotmail.com> ---
I can't reproduce this issue againt Windows XP platform
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #11 from Armin Le Grand <Ar...@me.com> ---
ALG: I have checked what happens, it's pretty complicated :-) Looks as if
aShapeProp.getProperty( xDocModel, PROP_Model ) (in
oox/source/drawingml/shape.cxx) does not get a chart model. Digging deeper...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #15 from Armin Le Grand <Ar...@me.com> ---
ALG: To check I have changed the getPropertyValue call in unoshap4.cxx:470 to
explicitely calling the SvxShape implementation. This did not work, I also had
to do this with the setPropertyValue call in line 501. With both adapted it
works on the mac, the chart gets displayed.
It seems as if the standard to call the SvxShape implementation by default has
changed on the mac, probably by using a newer xcode compiler than with the
3.4beta version. Thus, one solution would be to compile with the compiler
version used at that time.
This is no good solution, though. Explicit calls are also not, it will just fix
this single symptom but not the changed calling order of multiple inherited
virtual functions on the mac. It may be a known problem/change on the mac xcode
compiler, I will have to investigate. Maybe there is a compiler switch
available to turn the behaviour to the original one.
Still no good solution. All multiple derivated functions would have to be
overloaded at the class where they lead to multiple derivation and in the
implementation the correct one (which is not even clear) would have to be
called. This seems to have been (and is except on the mac) the first class
given in the declaration (here this is class SVX_DLLPUBLIC SvxShapeText :
public SvxShape, public SvxUnoTextBase). I also need to find out if this is C++
standard and if the mac behaviour is an error.
Does someone have a simple and safe solution?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG: Line 752 is the note that the OLE is not found, the problem is more line
171. It looks like the property CLSID cannot be set at import time (it contains
the unique identifier for the Ole to load). This can go wrong when either the
value in the given any is not of the expected type or the slot for CLSID is not
allowed. Need to check deeper, I do not know too much about PropertySets.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com
--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
ALG: I get the following assertions:
Error: Disconnect() called on disconnected object!
Error: PropertySet::implSetPropertyValue - cannot set property "CLSID" From
File
/Users/armin_le_grand/aoo/svn_trunk10/main/oox/source/helper/propertyset.cxx at
Line 171
Error: No embedded object is given! From File
/Users/armin_le_grand/aoo/svn_trunk10/main/sc/source/core/data/documen5.cxx at
Line 752
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
Flags|3.4.1_release_blocker? |3.4.1_release_blocker+
--- Comment #20 from jsc@apache.org ---
set release blocker flag to 3.4.1
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #14 from Armin Le Grand <Ar...@me.com> ---
ALG: SvxShape and SvxUnoTextBaseRange (from which SvxUnoTextBase is derived)
both have a virtual getPropertyValue. Thus, this method gets double derived to
SvxOle2Shape. The mac and win compiler have different interpretations which one
has to be called. What may be the C++ standard behaviour for this? We have to
check...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #12 from Armin Le Grand <Ar...@me.com> ---
ALG: Reason is from unoshap4.cxx:470 mac calls
SvxUnoTextRangeBase::getPropertyValue, while the win version calls
SvxShape::getPropertyValue which is correct. Why....?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
Terry Yang <po...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |polo8495@hotmail.com
--- Comment #22 from Terry Yang <po...@hotmail.com> ---
Verify fixed on trunk rev.1351249, the chart in sample file display well on
Mac(10.7.4)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
Terry Yang <po...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #25 from Terry Yang <po...@hotmail.com> ---
Close this bug
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Flags| |3.4.1_release_blocker?
--- Comment #19 from Armin Le Grand <Ar...@me.com> ---
ALG: Fixed in trunk, request AOO3.4.1 blocker flag.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #4 from matthew@mcgillis.org ---
OpenOffice.org 3.4.0
AOO340m1(Build:9590) - Rev. 1327774
2012-04-19 03:33:29
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #18 from Armin Le Grand <Ar...@me.com> ---
Created attachment 77805
--> https://issues.apache.org/ooo/attachment.cgi?id=77805&action=edit
Solves the wrong get/setPropertyValue calls in SvxShapeText (and thus in
SvxOle2Shape)
--
You are receiving this mail because:
You are the assignee for the bug.
3.4.1_release_blocker granted: [Bug 119337] xlsx import with chart
is not displayed
Posted by bu...@apache.org.
jsc@apache.org has granted Armin Le Grand <Ar...@me.com>'s request for
3.4.1_release_blocker:
Bug 119337: xlsx import with chart is not displayed
https://issues.apache.org/ooo/show_bug.cgi?id=119337
------- Additional Comments from jsc@apache.org
set release blocker flag to 3.4.1
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #24 from Terry Yang <po...@hotmail.com> ---
Verify fixed on AOO34 Branch r1354891
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
Olaf Felka <ol...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |regression
Priority|P1 |P3
Version|AOO350 |AOO340
--- Comment #10 from Olaf Felka <ol...@gmx.de> ---
This is not a P1 issue! AOO won't get unusable by this problem. And the version
is still AOO340 as the issue has been found in that version!!
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
hdu@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucalcin@tin.it
--- Comment #27 from hdu@apache.org ---
*** Bug 120369 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #17 from Armin Le Grand <Ar...@me.com> ---
ALG: There were also the statements
using SvxUnoTextRangeBase::setPropertyValue;
using SvxUnoTextRangeBase::getPropertyValue;
in SvxShapeText. It looks as if the mac compiler is the first who really used
this now in class-local implementations. Removing them allowed to find the
places where the call was ambigous. There are just three places, one
getPropertyValue and two setPropertyValue calls. All three are clearly aimed at
SvxShape:: implementations due to the slot name. I changed all three and
removedthe using statements. Checked on mac an windows, works as expected.
Adding patch. Also committing to trunk.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
zhao xia <do...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Version|recent-trunk |AOO350
--- Comment #9 from zhao xia <do...@hotmail.com> ---
Improve the priority to P1 and move this defect to AOO35 as AOO 350 candidate
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
Marcus <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|blocker |major
--- Comment #16 from Marcus <ma...@apache.org> ---
not a blocker issue
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
--- Comment #21 from hdu@apache.org ---
I wonder why on Windows and Unix SvxShape::getPropertyValue got called even
though "using SvxUnoTextRangeBase::getPropertyValue" was explicitly requested.
If the compilers had simply ignored the using-lines they should at least have
complained about the ambiguity, what is what they do when the using-lines are
removed. Doing the exact opposite and not even giving a warning is very strange
and could lead to many other errors. E.g. unoshape.hxx contains a lot many more
of such using-lines.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119337] xlsx import with chart is not displayed
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119337
Andre <af...@a-w-f.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |af@a-w-f.de
Ever confirmed|0 |1
--- Comment #5 from Andre <af...@a-w-f.de> ---
I can reproduce the issue on MacOSX (10.7.3) on a freshly build office. Only
the OLE replacement icon is shown where the chart should be.
--
You are receiving this mail because:
You are the assignee for the bug.
3.4.1_release_blocker requested: [Bug 119337] xlsx import with chart
is not displayed
Posted by bu...@apache.org.
Armin Le Grand <Ar...@me.com> has asked for 3.4.1_release_blocker:
Bug 119337: xlsx import with chart is not displayed
https://issues.apache.org/ooo/show_bug.cgi?id=119337
------- Additional Comments from Armin Le Grand <Ar...@me.com>
ALG: Fixed in trunk, request AOO3.4.1 blocker flag.