[GitHub] [ratis] szetszwo commented on a change in pull request #489: RATIS-1390. Bootstrapping Peer should always try to install a snapshot the first time.

[GitBox <gi...@apache.org>]

szetszwo commented on a change in pull request #489:
URL: https://github.com/apache/ratis/pull/489#discussion_r689215340



##########
File path: ratis-server-api/src/main/java/org/apache/ratis/server/leader/FollowerInfo.java
##########
@@ -52,6 +52,14 @@
   /** Set follower's snapshotIndex. */
   void setSnapshotIndex(long newSnapshotIndex);
 
+  /** Acknowledge that Follower attempted to install a snapshot. It does not guarantee that the installation was
+   * successful. This helps to determine whether Follower can come out of bootstrap process. */
+  void ackInstallSnapshotAttempt();

Review comment:
       Let's use a name similar to hasAttemptedToInstallSnapshot().  How about "setAttemptedToInstallSnapshot"?

##########
File path: ratis-proto/src/main/proto/Raft.proto
##########
@@ -148,6 +148,7 @@ enum InstallSnapshotResult {
   IN_PROGRESS = 2;
   ALREADY_INSTALLED = 3;
   CONF_MISMATCH = 4;
+  NULL_SNAPSHOT = 5;

Review comment:
       How about calling it as SNAPSHOT_UNAVALIABLE?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org