You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ri...@apache.org on 2022/03/21 15:54:22 UTC
[pinot] branch master updated: fix checkstyle (#8377)
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 24d4fd2 fix checkstyle (#8377)
24d4fd2 is described below
commit 24d4fd268d28473ffd3ce1ce262322391810f356
Author: Richard Startin <ri...@startree.ai>
AuthorDate: Mon Mar 21 15:53:46 2022 +0000
fix checkstyle (#8377)
---
.../pinot/core/data/manager/offline/DimensionTableDataManager.java | 2 --
.../pinot/core/data/manager/offline/DimensionTableDataManagerTest.java | 1 -
2 files changed, 3 deletions(-)
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
index 46a3b11..3cbfea7 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
@@ -143,12 +143,10 @@ public class DimensionTableDataManager extends OfflineTableDataManager {
}
}
}
-
ZkHelixPropertyStore<ZNRecord> propertyStore = _helixManager.getHelixPropertyStore();
Schema tableSchema = ZKMetadataProvider.getTableSchema(propertyStore, _tableNameWithType);
List<String> primaryKeyColumns = tableSchema.getPrimaryKeyColumns();
return new DimensionTable(tableSchema, primaryKeyColumns, map);
-
} finally {
for (SegmentDataManager segmentManager : segmentManagers) {
releaseSegment(segmentManager);
diff --git a/pinot-core/src/test/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManagerTest.java b/pinot-core/src/test/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManagerTest.java
index dbce8cb..7eb74e5 100644
--- a/pinot-core/src/test/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManagerTest.java
+++ b/pinot-core/src/test/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManagerTest.java
@@ -224,6 +224,5 @@ public class DimensionTableDataManagerTest {
Assert.assertNotNull(teamCitySpec, "Should return spec for existing column");
Assert.assertEquals(teamCitySpec.getDataType(), FieldSpec.DataType.STRING,
"Should return correct data type for teamCity column");
-
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org