[jira] [Comment Edited] (GEODE-304) Fix all Pulse unit and integration tests

["Nitin Lamba (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946081#comment-14946081 ] 

Nitin Lamba edited comment on GEODE-304 at 10/7/15 12:45 AM:
-------------------------------------------------------------

Thanks [~dcavender]! I'm sure the URL isn't related to properties file, rather it is hard-coded in the BaseServiceTest class (lines 65-68). Following is the set of tests I ran using latest Firefox browser (gradle script and test report is attached):
1. *junit tests* under src/test/java/com/vmware/gemfire/tools/pulse/tests/junit:
These are based on BaseServiceTest and try to connect to the remote server (pnq-pratik.vmware.com:8081) looking for pulse-7.5 context. I think multiple pulse war files may have been installed on that server
2. *PulseUITests* under src/test/java/com/vmware/gemfire/tools/pulse/testbed/driver:
These tests try to start Pulse standalone within Tomcat server, and connect to a simulated test bed (a mock Geode cluster). Certain properties file are passed around but not used and it is not clear how the Pulse application connects to this testbed. The primary failure is due to a missing UI element (Data View) that points to an HTML file (dataView.html) which doesn't exist in the codebase. My guess is that this one is an old test suite and should be ignored
3. *PulseAutomatedTests* under src/test/java/com/vmware/gemfire/tools/pulse/tests:
This inherits tests from PulseBaseTests and PulseTests. By far, the most comprehensive test suite I found.
These tests try to start Pulse standalone within Tomcat server, and connect to a simulated JMX Server on port 9999. I had to change the pulse.properties file as:
{code}
pulse.useLocator=false
pulse.host=localhost
pulse.port=9999
{code}

About 70% of tests pass so I think my setup is still incorrect. I also see a lot of ignored tests because the classes have those hardcoded, such as:
{code}
Ignore("Not part of Pulse-Cedar 7.5 release")
Ignore("WIP")
Ignore("For Gemfire XD")
{code}

It'll really help if someone from the Pivotal team can describe the exact testbed setup so that all the tests pass. Once that is cleared, the next step is to have FireFox browser installed on CI/ nightly build servers.


was (Author: nlamba):
Thanks [~dcavender]! I'm sure the URL isn't related to properties file, rather it is hard-coded in the BaseServiceTest class (lines 65-68). Following is the set of tests I ran with my current findings using latest Firefox browser (gradle script and test report is attached):
1. *junit tests* under src/test/java/com/vmware/gemfire/tools/pulse/tests/junit:
These are based on BaseServiceTest and try to connect to the remote server (pnq-pratik.vmware.com:8081) looking for pulse-7.5 context. I think multiple pulse war files may have been installed on that server
2. *PulseUITests* under src/test/java/com/vmware/gemfire/tools/pulse/testbed/driver:
These tests try to start Pulse standalone within Tomcat server, and connect to a simulated test bed (a mock Geode cluster). Certain properties file are passed around but not used and it is not clear how the Pulse application connects to this testbed. The primary failure is due to a missing UI element (Data View) that points to an HTML file (dataView.html) which doesn't exist in the codebase. My guess is that this one is an old test suite and should be ignored
3. *PulseAutomatedTests* under src/test/java/com/vmware/gemfire/tools/pulse/tests:
This inherits tests from PulseBaseTests and PulseTests. By far, the most comprehensive test suite I found.
These tests try to start Pulse standalone within Tomcat server, and connect to a simulated JMX Server on port 9999. I had to change the pulse.properties file as:
{code}
pulse.useLocator=false
pulse.host=localhost
pulse.port=9999
{code}

About 70% of tests pass so I think my setup is still incorrect. I also see a lot of ignored tests because the classes have those hardcoded, such as:
{code}
Ignore("Not part of Pulse-Cedar 7.5 release")
Ignore("WIP")
Ignore("For Gemfire XD")
{code}

It'll really help if someone from the Pivotal team can describe the exact testbed setup so that all the tests pass. Once that is cleared, the next step is to have FireFox browser installed on CI/ nightly build servers.

> Fix all Pulse unit and integration tests
> ----------------------------------------
>
>                 Key: GEODE-304
>                 URL: https://issues.apache.org/jira/browse/GEODE-304
>             Project: Geode
>          Issue Type: Sub-task
>          Components: management & tools
>            Reporter: Nitin Lamba
>            Assignee: Nitin Lamba
>         Attachments: build.gradle, test-progress.txt, test.zip
>
>
> Automated/ UI (Selenium) tests are failing; it seems that the library needs to be updated. Just swapping with the new jar file doesn't work, so tests need to be essentially re-implemented.
> junit tests inherited from BaseServiceTest also fail (not able to connect to host). Lines 65-68 look suspiciously old code, probably not even testable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)