[GitHub] [pinot] priyen commented on a diff in pull request #10926: Realtime pre-aggregation for Distinct Count HLL & Big Decimal

["priyen (via GitHub)" <gi...@apache.org>]

priyen commented on code in PR #10926:
URL: https://github.com/apache/pinot/pull/10926#discussion_r1252415123


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/SumValueAggregator.java:
##########
@@ -37,11 +37,17 @@ public DataType getAggregatedValueType() {
 
   @Override
   public Double getInitialAggregatedValue(Number rawValue) {
+    if (rawValue == null) {

Review Comment:
   It could be if the field is null on some of the incoming stream messages. You could always guard against this by filtering out the messages during ingestion, but I think returning 0.0 here as the default should be harmless since this is the sum aggregator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org