You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/20 23:52:04 UTC
[GitHub] codecov-io edited a comment on issue #5682: [bugfix] making
secondary_metric optional
codecov-io edited a comment on issue #5682: [bugfix] making secondary_metric optional
URL: https://github.com/apache/incubator-superset/pull/5682#issuecomment-414501217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5682?src=pr&el=h1) Report
> Merging [#5682](https://codecov.io/gh/apache/incubator-superset/pull/5682?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/cdd348ab94b075cf3505b7e2dd84206dc3aede82?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `6.66%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5682/graphs/tree.svg?height=150&width=650&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5682?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5682 +/- ##
=========================================
- Coverage 63.51% 63.5% -0.01%
=========================================
Files 360 360
Lines 22904 22904
Branches 2551 2555 +4
=========================================
- Hits 14548 14546 -2
- Misses 8341 8343 +2
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5682?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `45.92% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/explore/visTypes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3Zpc1R5cGVzLmpzeA==) | `57.14% <ø> (ø)` | :arrow_up: |
| [.../assets/src/visualizations/parallel\_coordinates.js](https://codecov.io/gh/apache/incubator-superset/pull/5682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wYXJhbGxlbF9jb29yZGluYXRlcy5qcw==) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/sunburst.js](https://codecov.io/gh/apache/incubator-superset/pull/5682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9zdW5idXJzdC5qcw==) | `0% <0%> (ø)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.28% <33.33%> (-0.08%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5682?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5682?src=pr&el=footer). Last update [cdd348a...c8a52e1](https://codecov.io/gh/apache/incubator-superset/pull/5682?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org