[PR] ci(asf.yaml): stop blocking merge on unresolved review threads [magpie]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk opened a new pull request, #1155:
URL: https://github.com/apache/magpie/pull/1155

   ## Summary
   
   - `required_conversation_resolution: true` made **any** open review thread a hard merge gate. With the approval requirement currently lifted, it was the one gate a reviewer could trip by accident.
   - The failure mode is specific and was hit repeatedly during a review pass over #1141–#1145: a reviewer leaves a nit they explicitly mark *non-blocking*, the PR becomes unmergeable, and the reviewer resolves their own advisory comment purely to unblock the merge. That destroys the signal — an unresolved thread should mean "the author hasn't looked at this yet", not "the merge button is stuck".
   - Unresolved threads stay visible in the PR UI; they are simply no longer a hard gate. `zizmor` / `prek` / `tests-ok` and `required_linear_history` are untouched, so nothing merges without green CI.
   
   ## Not included: Actions workflow approval
   
   The other half of the request — stop requiring maintainer approval for contributors' workflow runs — **cannot be expressed in `.asf.yaml`.** I checked the asfyaml implementation rather than guessing: [`asfyaml/feature/github/`](https://github.com/apache/infrastructure-asfyaml/tree/main/asfyaml/feature/github) has modules for branch protection, rulesets, merge buttons, collaborators, pull requests, protected tags, pages, environments and Copilot review — but **no Actions module**, and no `actions` / `fork` / `approval` keys anywhere in the feature set.
   
   That setting lives in GitHub's *Settings → Actions → General → Fork pull request workflows from outside collaborators*. It needs either a repo admin or an ASF Infra (JIRA) request. Worth noting `potiuk` currently has `push`/`triage` but not `admin` or `maintain` on this repo, so it needs Infra.
   
   Empirically the repo is on **"Require approval for all outside collaborators"** rather than the first-time-contributor default: `AmirF194` is a returning `CONTRIBUTOR` with three open PRs and every run is still gated. Moving it to *"Require approval for first-time contributors"* would unblock the recurring contributors while keeping the guard for brand-new accounts.
   
   ## Type of change
   
   - [x] CI / dev loop (`prek`, workflows, validators)
   
   ## Test plan
   
   - [x] YAML parses; no other key touched (single-key diff plus its comment block).
   - [x] `prek` passes on the changed file.
   - [x] Verified against the asfyaml source that `required_conversation_resolution` is a supported `protected_branches` key (`asfyaml/feature/github/branch_protection.py:140`), so this lands rather than being silently ignored.
   - ASF Infra reconciles `protected_branches` within a few minutes of merge to `main`.
   
   ## Linked issues
   
   Follow-up to the review pass on #1141, #1144, #1145, #1143, #1142.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ci(asf.yaml): stop blocking merge on unresolved review threads [magpie]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk merged PR #1155:
URL: https://github.com/apache/magpie/pull/1155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org