You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/07/09 11:29:46 UTC

[GitHub] markusthoemmes commented on a change in pull request #3855: Add invoker container name to health protocol

markusthoemmes commented on a change in pull request #3855: Add invoker container name to health protocol
URL: https://github.com/apache/incubator-openwhisk/pull/3855#discussion_r200965886
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
 ##########
 @@ -291,7 +291,9 @@ class ShardingContainerPoolBalancer(config: WhiskConfig, controllerInstance: Con
     val start = transid.started(
       this,
       LoggingMarkers.CONTROLLER_KAFKA,
-      s"posting topic '$topic' with activation id '${msg.activationId}'",
+      invoker.hostname
+        .map(h => s"posting topic '$topic' to invoker '$h' with activation id '${msg.activationId}'")
+        .getOrElse(s"posting topic '$topic' with activation id '${msg.activationId}'"),
 
 Review comment:
   Could we also print the whole instanceId?
   
   As in: `s"posting to $invoker using topic '$topic' with activation id '${msg.activationId}'"`
   
   Should then log the whole case class with its respective members.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services