You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2013/01/09 05:15:53 UTC
Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job URLs
spawned by Pig
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/
-----------------------------------------------------------
Review request for oozie.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1160
*WIP*
This addresses bug OOZIE-1160.
https://issues.apache.org/jira/browse/OOZIE-1160
Diffs
-----
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1430674
trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1430674
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonWorkflowAction.java 1430674
trunk/webapp/src/main/webapp/oozie-console.js 1430674
Diff: https://reviews.apache.org/r/8897/diff/
Testing
-------
e-2-e tested
Thanks,
Mona Chitnis
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/#review15498
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java
<https://reviews.apache.org/r/8897/#comment33462>
as discussed, this file needs to be copied to oozie server
for storing the external child id's in database.
- Virag Kothari
On Jan. 17, 2013, 1:07 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8897/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 1:07 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> This addresses bug OOZIE-1160.
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1432320
> trunk/webapp/src/main/webapp/oozie-console.js 1432320
>
> Diff: https://reviews.apache.org/r/8897/diff/
>
>
> Testing
> -------
>
> e-2-e tested
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/#review15579
-----------------------------------------------------------
Few comments discussed offline..also put below for tracking purpose
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/8897/#comment33661>
Move this block to place where job is not successful.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/8897/#comment33662>
As getActionData() does other stuff, retrieve only the external Ids here
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
<https://reviews.apache.org/r/8897/#comment33663>
change signature of method by removing the first argument
- Virag Kothari
On Jan. 22, 2013, 10:56 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8897/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2013, 10:56 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> This addresses bug OOZIE-1160.
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 1436833
> trunk/webapp/src/main/webapp/oozie-console.js 1436833
>
> Diff: https://reviews.apache.org/r/8897/diff/
>
>
> Testing
> -------
>
> e-2-e tested
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/#review15633
-----------------------------------------------------------
Ship it!
+1..few minor comments discussed offline
- Virag Kothari
On Jan. 23, 2013, 1:33 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8897/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 1:33 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> This addresses bug OOZIE-1160.
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1436833
> trunk/webapp/src/main/webapp/oozie-console.js 1436833
>
> Diff: https://reviews.apache.org/r/8897/diff/
>
>
> Testing
> -------
>
> e-2-e tested
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/
-----------------------------------------------------------
(Updated Jan. 23, 2013, 1:33 a.m.)
Review request for oozie.
Changes
-------
Addressed comments
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1160
This addresses bug OOZIE-1160.
https://issues.apache.org/jira/browse/OOZIE-1160
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1436833
trunk/webapp/src/main/webapp/oozie-console.js 1436833
Diff: https://reviews.apache.org/r/8897/diff/
Testing
-------
e-2-e tested
Thanks,
Mona Chitnis
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Mona Chitnis <mo...@yahoo.in>.
> On Jan. 22, 2013, 10:03 p.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 1041
> > <https://reviews.apache.org/r/8897/diff/6/?file=251105#file251105line1041>
> >
> > Abstract this details here and have a method like handleFailure() and override it in PigAE
using method name 'getChildIds' itself, instead of handleFailure which sounds bigger in scope
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/#review15586
-----------------------------------------------------------
On Jan. 22, 2013, 9:46 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8897/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2013, 9:46 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> This addresses bug OOZIE-1160.
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1436833
> trunk/webapp/src/main/webapp/oozie-console.js 1436833
>
> Diff: https://reviews.apache.org/r/8897/diff/
>
>
> Testing
> -------
>
> e-2-e tested
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/#review15586
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/8897/#comment33670>
Abstract this details here and have a method like handleFailure() and override it in PigAE
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
<https://reviews.apache.org/r/8897/#comment33671>
move the finally to the inner try-catch.
- Virag Kothari
On Jan. 22, 2013, 9:46 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8897/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2013, 9:46 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> This addresses bug OOZIE-1160.
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 1436833
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1436833
> trunk/webapp/src/main/webapp/oozie-console.js 1436833
>
> Diff: https://reviews.apache.org/r/8897/diff/
>
>
> Testing
> -------
>
> e-2-e tested
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/
-----------------------------------------------------------
(Updated Jan. 22, 2013, 9:46 p.m.)
Review request for oozie.
Changes
-------
addressed comments. final patch
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1160
This addresses bug OOZIE-1160.
https://issues.apache.org/jira/browse/OOZIE-1160
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1436833
trunk/webapp/src/main/webapp/oozie-console.js 1436833
Diff: https://reviews.apache.org/r/8897/diff/
Testing
-------
e-2-e tested
Thanks,
Mona Chitnis
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/
-----------------------------------------------------------
(Updated Jan. 22, 2013, 10:56 a.m.)
Review request for oozie.
Changes
-------
Incorporated Virag's review comment
- Job IDs fetched for failed Launchers too
- modularized the UI code into functions
- added refresh function to WF Action Info
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1160
This addresses bug OOZIE-1160.
https://issues.apache.org/jira/browse/OOZIE-1160
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1436833
trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 1436833
trunk/webapp/src/main/webapp/oozie-console.js 1436833
Diff: https://reviews.apache.org/r/8897/diff/
Testing
-------
e-2-e tested
Thanks,
Mona Chitnis
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/
-----------------------------------------------------------
(Updated Jan. 17, 2013, 1:07 a.m.)
Review request for oozie.
Changes
-------
patch updated following offline discussion with Virag to store Hadoop Job Ids to file even if PigRunner.run returns PigStats unsuccessful.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1160
This addresses bug OOZIE-1160.
https://issues.apache.org/jira/browse/OOZIE-1160
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1432320
trunk/webapp/src/main/webapp/oozie-console.js 1432320
Diff: https://reviews.apache.org/r/8897/diff/
Testing
-------
e-2-e tested
Thanks,
Mona Chitnis
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/#review15372
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Jan. 16, 2013, 12:36 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8897/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2013, 12:36 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> This addresses bug OOZIE-1160.
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> Diffs
> -----
>
> trunk/webapp/src/main/webapp/oozie-console.js 1432320
>
> Diff: https://reviews.apache.org/r/8897/diff/
>
>
> Testing
> -------
>
> e-2-e tested
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/
-----------------------------------------------------------
(Updated Jan. 16, 2013, 12:36 a.m.)
Review request for oozie.
Changes
-------
1. Moved entire logic to just the oozie-console javascript code since we are manipulating existing fields and need not change JSON response object
2. Added numbering to the child job URLs
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1160
This addresses bug OOZIE-1160.
https://issues.apache.org/jira/browse/OOZIE-1160
Diffs (updated)
-----
trunk/webapp/src/main/webapp/oozie-console.js 1432320
Diff: https://reviews.apache.org/r/8897/diff/
Testing
-------
e-2-e tested
Thanks,
Mona Chitnis
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/#review15349
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonWorkflowAction.java
<https://reviews.apache.org/r/8897/#comment33018>
If external childIDs are already part of the json response, can we just use it and construct the child job urls in the browser instead of constructing in server and sending them in childJobURLs?
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonWorkflowAction.java
<https://reviews.apache.org/r/8897/#comment33016>
Would be clean to have a JSON primitive String array instead of , separated urls.
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonWorkflowAction.java
<https://reviews.apache.org/r/8897/#comment33017>
Will this logic work with hadoop 1.x?
- Rohini Palaniswamy
On Jan. 15, 2013, 4:31 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8897/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 4:31 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> This addresses bug OOZIE-1160.
> https://issues.apache.org/jira/browse/OOZIE-1160
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1432320
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1432320
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonWorkflowAction.java 1432320
> trunk/webapp/src/main/webapp/oozie-console.js 1432320
>
> Diff: https://reviews.apache.org/r/8897/diff/
>
>
> Testing
> -------
>
> e-2-e tested
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [GUI] OOZIE-1160 Oozie web-console to display all job
URLs spawned by Pig
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/
-----------------------------------------------------------
(Updated Jan. 15, 2013, 4:31 a.m.)
Review request for oozie.
Changes
-------
Moved URLs to separate tab, fixed 'undefined' problems erupting from ExtJS when clicking on other actions,
Added a screenshot for illustration
Looks best on Firefox, tested with Chrome too but the button to click the Console URL appears on the left instead of the standard right.
Description (updated)
-------
https://issues.apache.org/jira/browse/OOZIE-1160
This addresses bug OOZIE-1160.
https://issues.apache.org/jira/browse/OOZIE-1160
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1432320
trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 1432320
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonWorkflowAction.java 1432320
trunk/webapp/src/main/webapp/oozie-console.js 1432320
Diff: https://reviews.apache.org/r/8897/diff/
Testing
-------
e-2-e tested
Thanks,
Mona Chitnis