You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/26 14:40:38 UTC
[GitHub] [airflow] khalidmammadov opened a new pull request #20504: Fixing various issues in utils folder reported by MyPy (part 1)
khalidmammadov opened a new pull request #20504:
URL: https://github.com/apache/airflow/pull/20504
Part of https://github.com/apache/airflow/issues/19891
Fixes number of issues reported by MyPy:
- Handling case when regex does not match anything
- Providing possible types for "template_env" variable explicitly
- Removed Overloading for the functions. I don't see any reason why they are necessary. @ashb Please comment otherwise as they were added in #20000
- Better handling for dynamic field access for `localize` method
- `relativedelta` does not define type for `seconds` and accepts float (I tested empirically) as well which MyPy complains that is not allowed. So, ignoring
- Added one more test case for correct_maybe_zipped to check for an empty input
This is Part 1 for (airflow/utils) and will do Part 2 in a separate PR to keep scope small for review and focus.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov closed pull request #20504: Fixing various issues in utils folder reported by MyPy
Posted by GitBox <gi...@apache.org>.
khalidmammadov closed pull request #20504:
URL: https://github.com/apache/airflow/pull/20504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #20504: Fixing various issues in utils folder reported by MyPy
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #20504:
URL: https://github.com/apache/airflow/pull/20504#issuecomment-1002287711
Closing in favor of #20482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org