You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/01/12 13:19:43 UTC
Review Request 55456: Fixed include order in "launcher/executor.cpp".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55456/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
Diff: https://reviews.apache.org/r/55456/diff/
Testing
-------
None: not a functional change
Thanks,
Alexander Rukletsov
Re: Review Request 55456: Fixed include order in
"launcher/executor.cpp".
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Jan. 13, 2017, 12:33 p.m., Gast�n Kleiman wrote:
> > src/launcher/executor.cpp, line 82
> > <https://reviews.apache.org/r/55456/diff/1/?file=1603827#file1603827line82>
> >
> > According to our style guide, this should be the first include =)
Good catch!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55456/#review161512
-----------------------------------------------------------
On Jan. 12, 2017, 1:19 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55456/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 1:19 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
>
> Diff: https://reviews.apache.org/r/55456/diff/
>
>
> Testing
> -------
>
> None: not a functional change
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55456: Fixed include order in
"launcher/executor.cpp".
Posted by Gastón Kleiman <ga...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55456/#review161512
-----------------------------------------------------------
src/launcher/executor.cpp (line 79)
<https://reviews.apache.org/r/55456/#comment232808>
According to our style guide, this should be the first include =)
- Gast�n Kleiman
On Jan. 12, 2017, 1:19 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55456/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 1:19 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
>
> Diff: https://reviews.apache.org/r/55456/diff/
>
>
> Testing
> -------
>
> None: not a functional change
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55456: Fixed include order in
"launcher/executor.cpp".
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55456/#review162558
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 20, 2017, 2:49 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55456/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 2:49 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp b42743b1aceab511f8e4dbef9f321e986e34f4ad
>
> Diff: https://reviews.apache.org/r/55456/diff/
>
>
> Testing
> -------
>
> None: not a functional change
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55456: Fixed include order in
"launcher/executor.cpp".
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55456/
-----------------------------------------------------------
(Updated Jan. 20, 2017, 2:49 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp b42743b1aceab511f8e4dbef9f321e986e34f4ad
Diff: https://reviews.apache.org/r/55456/diff/
Testing
-------
None: not a functional change
Thanks,
Alexander Rukletsov
Re: Review Request 55456: Fixed include order in
"launcher/executor.cpp".
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55456/
-----------------------------------------------------------
(Updated Jan. 19, 2017, 5:41 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
Diff: https://reviews.apache.org/r/55456/diff/
Testing
-------
None: not a functional change
Thanks,
Alexander Rukletsov
Re: Review Request 55456: Fixed include order in
"launcher/executor.cpp".
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55456/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 10:39 a.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
Diff: https://reviews.apache.org/r/55456/diff/
Testing
-------
None: not a functional change
Thanks,
Alexander Rukletsov
Re: Review Request 55456: Fixed include order in
"launcher/executor.cpp".
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55456/#review162061
-----------------------------------------------------------
src/launcher/executor.cpp (line 17)
<https://reviews.apache.org/r/55456/#comment233304>
This should not be at the top.
- Vinod Kone
On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55456/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 9:31 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
>
> Diff: https://reviews.apache.org/r/55456/diff/
>
>
> Testing
> -------
>
> None: not a functional change
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55456: Fixed include order in
"launcher/executor.cpp".
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55456/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 9:31 a.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Changes
-------
Gast�n's comments.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
Diff: https://reviews.apache.org/r/55456/diff/
Testing
-------
None: not a functional change
Thanks,
Alexander Rukletsov