You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by afine <gi...@git.apache.org> on 2017/10/07 22:08:32 UTC
[GitHub] zookeeper pull request #396: ZOOKEEPER-2915: Use "strict" conflict managemen...
GitHub user afine opened a pull request:
https://github.com/apache/zookeeper/pull/396
ZOOKEEPER-2915: Use "strict" conflict management in ivy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2915_3.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #396
----
commit ea28ddc7ecc4eebe0fe1af2fb54dcabe578348c1
Author: Abraham Fine <af...@apache.org>
Date: 2017-10-06T21:43:05Z
ZOOKEEPER-2915: Use "strict" conflict management in ivy
----
---
[GitHub] zookeeper issue #396: ZOOKEEPER-2915: Use "strict" conflict management in iv...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/396
@phunt Egah. This patch is correct and I fixed the other one (the one based on master).
The end result of this patch should be, when running the tests, all dependencies from ivy should be available in one directory (build/test/lib) and build/lib should NOT be in the classpath.
---
[GitHub] zookeeper issue #396: ZOOKEEPER-2915: Use "strict" conflict management in iv...
Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/396
@afine please close this PR manually.
---
[GitHub] zookeeper issue #396: ZOOKEEPER-2915: Use "strict" conflict management in iv...
Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/396
lgtm. +1 Thanks Abe.
---
[GitHub] zookeeper pull request #396: ZOOKEEPER-2915: Use "strict" conflict managemen...
Posted by afine <gi...@git.apache.org>.
Github user afine closed the pull request at:
https://github.com/apache/zookeeper/pull/396
---
[GitHub] zookeeper issue #396: ZOOKEEPER-2915: Use "strict" conflict management in iv...
Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/396
@afine something seems wrong with this patch compared to master patch #397
On master there are no dup'd libraries in build/test/lib after "ant clean compile-test" - in this patch (3.4) I see many of the main libs dup'd into build/test/lib. Can you LMK what's what?
---