You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/10/25 17:58:50 UTC
[Impala-ASF-CR] Update .gitignore
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11787
Change subject: Update .gitignore
......................................................................
Update .gitignore
A few unversioned artifacts crept in over time without corresponding
.gitignore entries. These are the updates based on the git status output
on my dev env.
Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
---
M .gitignore
A common/yarn-extras/.gitignore
M fe/.gitignore
M fe/src/test/resources/.gitignore
A lib/python/.gitignore
5 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/11787/1
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Update .gitignore
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 4:
(3 comments)
I added the requested files. I don't think it really makes sense for me in future to add everyone's pet .gitignore entry though since you know what files you have on your system and I don't.
http://gerrit.cloudera.org:8080/#/c/11787/3/.gitignore
File .gitignore:
http://gerrit.cloudera.org:8080/#/c/11787/3/.gitignore@72
PS3, Line 72: .gdbinit
> .gdbinit ?
Done
http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore
File common/yarn-extras/.gitignore:
http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore@10
PS3, Line 10: *~
> probably worth adding to the top level one too.
Moved to top level
http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore@16
PS3, Line 16:
> same
Done
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 18:40:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Update .gitignore
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1161/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 18:23:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3366/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 18:39:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 22:19:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Update .gitignore
A few unversioned artifacts crept in over time without corresponding
.gitignore entries. These are the updates based on the git status output
on my dev env.
Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Reviewed-on: http://gerrit.cloudera.org:8080/11787
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M .gitignore
A common/yarn-extras/.gitignore
M fe/.gitignore
M fe/src/test/resources/.gitignore
A lib/python/.gitignore
M testdata/.gitignore
M testdata/cluster/.gitignore
7 files changed, 35 insertions(+), 0 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Update .gitignore
Posted by "Paul Rogers (Code Review)" <ge...@cloudera.org>.
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 3: Code-Review+1
Thanks! I've found a few more additions, many around the use of Eclipse. Probably easiest if I add those after you commit this set.
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 18:56:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11787
to look at the new patch set (#2).
Change subject: Update .gitignore
......................................................................
Update .gitignore
A few unversioned artifacts crept in over time without corresponding
.gitignore entries. These are the updates based on the git status output
on my dev env.
Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
---
M .gitignore
A common/yarn-extras/.gitignore
M fe/.gitignore
M fe/src/test/resources/.gitignore
A lib/python/.gitignore
M testdata/.gitignore
M testdata/cluster/.gitignore
7 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/11787/2
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] Update .gitignore
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 18:40:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1164/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 19:06:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Paul Rogers, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11787
to look at the new patch set (#4).
Change subject: Update .gitignore
......................................................................
Update .gitignore
A few unversioned artifacts crept in over time without corresponding
.gitignore entries. These are the updates based on the git status output
on my dev env.
Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
---
M .gitignore
A common/yarn-extras/.gitignore
M fe/.gitignore
M fe/src/test/resources/.gitignore
A lib/python/.gitignore
M testdata/.gitignore
M testdata/cluster/.gitignore
7 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/11787/4
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Update .gitignore
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11787/3/.gitignore
File .gitignore:
http://gerrit.cloudera.org:8080/#/c/11787/3/.gitignore@72
PS3, Line 72:
.gdbinit ?
http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore
File common/yarn-extras/.gitignore:
http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore@10
PS3, Line 10: .idea
probably worth adding to the top level one too.
http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore@16
PS3, Line 16: DS_Store
same
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 18:00:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Update .gitignore
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1177/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 19:08:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 3: Code-Review+1
Thanks for doing this! LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 18:23:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1163/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 18:59:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3367/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 18:40:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11787
to look at the new patch set (#3).
Change subject: Update .gitignore
......................................................................
Update .gitignore
A few unversioned artifacts crept in over time without corresponding
.gitignore entries. These are the updates based on the git status output
on my dev env.
Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
---
M .gitignore
A common/yarn-extras/.gitignore
M fe/.gitignore
M fe/src/test/resources/.gitignore
A lib/python/.gitignore
M testdata/.gitignore
M testdata/cluster/.gitignore
7 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/11787/3
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Update .gitignore
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 1:
We need to ignore more. These are files that I think should also be ignored.
$IMPALA_HOME/
.idea/
Impala.cbp
be/ASSEMBLER.cbp
lib/python/impala_py_lib.egg-info/
testdata/cluster/cdh6/
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 18:07:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 )
Change subject: Update .gitignore
......................................................................
Patch Set 2:
I think I addressed the ones you mentioned. I don't use some of those IDEs - intellij and codeblocks it looks like - so I can't confirm that I got all of the generated files for those.
--
To view, visit http://gerrit.cloudera.org:8080/11787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 18:21:59 +0000
Gerrit-HasComments: No