You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/08/10 09:40:06 UTC
[GitHub] [hive] maheshk114 commented on a change in pull request #2576: HIVE-25414 : Optimise Hive::addWriteNotificationLog: Reduce FS call per notification.
maheshk114 commented on a change in pull request #2576:
URL: https://github.com/apache/hive/pull/2576#discussion_r685860041
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
##########
@@ -2871,10 +2871,19 @@ public boolean skipProcessing(Task<?> task) {
Path loadPath = dpCtx.getRootPath();
FileSystem fs = loadPath.getFileSystem(conf);
int numDPCols = dpCtx.getNumDPCols();
- Map<Path, Optional<List<Path>>> allPartition = new HashMap<>();
+ Map<Path, Optional<List<FileStatus>>> allPartition = new HashMap<>();
if (dynamicPartitionSpecs != null) {
for (Map.Entry<String, List<Path>> partSpec : dynamicPartitionSpecs.entrySet()) {
- allPartition.put(new Path(loadPath, partSpec.getKey()), Optional.of(partSpec.getValue()));
+ if (Optional.of(partSpec.getValue()).isPresent()) {
Review comment:
I think it's same. I have just changed the data structure to have FileStatus instead of Path. If path is already null (isPresent is false) ..i am adding FileStatus as null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org