You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:41:17 UTC
[GitHub] [incubator-sedona] Imbruced opened a new pull request #538: Wkb shape serializer python
Imbruced opened a new pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538
## Is this PR related to a proposed Issue?
## What changes were proposed in this PR?
## How was this patch tested?
## Did this PR include necessary documentation updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on a change in pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on a change in pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#discussion_r699710472
##########
File path: python/sedona/core/serde/shape/enums.py
##########
@@ -0,0 +1,22 @@
+from enum import Enum
+
+
+class GeomEnum(Enum):
Review comment:
I used Shape types fro ShapeType enum within package org.apache.sedona.core.formatMapper.shapefileParser.parseUtils.shp or you meant
```java
SHAPE(0),
CIRCLE(1),
GEOMETRYCOLLECTION(2),
ENVELOPE(3);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu merged pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
jiayuasu merged pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-909701890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on a change in pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#discussion_r699509953
##########
File path: python/sedona/core/serde/shape/enums.py
##########
@@ -0,0 +1,22 @@
+from enum import Enum
+
+
+class GeomEnum(Enum):
Review comment:
@Imbruced Any reason why this only enumerates a few types instead of all types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-909190944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced removed a comment on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced removed a comment on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-909701943
Did I broke something in R package ? WDYT is better to have shape and wkb serializers in matrix or run tests twice ? (Python API holds on serializers so it is essential to run tests twice per serializer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-909190944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on a change in pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on a change in pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#discussion_r699710472
##########
File path: python/sedona/core/serde/shape/enums.py
##########
@@ -0,0 +1,22 @@
+from enum import Enum
+
+
+class GeomEnum(Enum):
Review comment:
I used Shape types fro ShapeType enum within package org.apache.sedona.core.formatMapper.shapefileParser.parseUtils.shp or you meant
```java
SHAPE(0),
CIRCLE(1),
GEOMETRYCOLLECTION(2),
ENVELOPE(3);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-909190944
need to fix python worklow, it should include tests for shape and wkb serializer based on file content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-911153057
@Imbruced R doc is in the R module folder. Let me merge this PR now and go back to @netanel246 PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-909954007
@jiayuasu Can you add @netanel246 to reviewers ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced removed a comment on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced removed a comment on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-909701943
Did I broke something in R package ? WDYT is better to have shape and wkb serializers in matrix or run tests twice ? (Python API holds on serializers so it is essential to run tests twice per serializer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on a change in pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#discussion_r699509953
##########
File path: python/sedona/core/serde/shape/enums.py
##########
@@ -0,0 +1,22 @@
+from enum import Enum
+
+
+class GeomEnum(Enum):
Review comment:
@Imbruced Any reason why this only enumerates a few types instead of all types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-910608215
1 @jiayuasu pushed changed workflow.
2 Is there any R docs ? It would be great to actually know hot to do not make regression within R package also.
3 I can update that after we merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-909705746
To be honest, this PR and major one needs documentation update, should I include them here or we update docs in @netanel246 PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-909702869
I can squash this PR (or we can squash while merging to master), sorry for additional commits, did anyone has a pleasure to use https://github.com/nektos/act to run workflows locally ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-909191299
And do not know why R workflow does not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on pull request #538: Wkb shape serializer python
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on pull request #538:
URL: https://github.com/apache/incubator-sedona/pull/538#issuecomment-910524160
@Imbruced
1. I don't think we need to test shape/wkb in all Python CI scenarios. Can we just just test Shape/WKT in GitHub Action Python Build 3.1.1 and Python 3.8?
2. I guess R build failure has nothing to do with your PR. Once we squash this PR to ShapeWKBSerDe branch, I will ask Yitao to take a look
3. Let's put the documentation update in the main PR. Once we fix my comment 1, we will squash and merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org