[jira] [Commented] (METRON-1338) Rat Check Should Ignore Vagrant Retry Files

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271245#comment-16271245 ] 

ASF GitHub Bot commented on METRON-1338:
----------------------------------------

GitHub user nickwallen opened a pull request:

    https://github.com/apache/metron/pull/855

    METRON-1338 Excluding retry files from RAT check

    When Vagrant fails, it generates a *.retry file. These files are ignored by Git, but will unnecessarily fail a build because of the Rat check. This has annoyed me to no end.
    
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
      ```
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickwallen/metron METRON-1338

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/855.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #855
    
----
commit 522f4116035265504ee4ef2a85e2475649673209
Author: Nick Allen <ni...@nickallen.org>
Date:   2017-11-29T13:28:44Z

    Excluding retry files from RAT check

----


> Rat Check Should Ignore Vagrant Retry Files
> -------------------------------------------
>
>                 Key: METRON-1338
>                 URL: https://issues.apache.org/jira/browse/METRON-1338
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>            Priority: Trivial
>             Fix For: 0.4.1
>
>
> When Vagrant fails, it generates a *.retry file.  These files are ignored by Git, but will unnecessarily fail a build because of the Rat check.  This has annoyed me to no end.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)