[GitHub] [activemq-nms-amqp] cjwmorgan-sol edited a comment on issue #8: AMQNET-591: Transactions support

[GitBox <gi...@apache.org>]

cjwmorgan-sol edited a comment on issue #8: AMQNET-591: Transactions support
URL: https://github.com/apache/activemq-nms-amqp/pull/8#issuecomment-517344936
 
 
   I've been taking a look at the source code changes there look alright to me.
   I've starting testing against two brokers, one that supports transactions (activemq artemis 2.9.0) and one that does not (solace broker).
   It has taken me some sometime to verify the changes as I've some run into issues that I think are unrelated to the transport support, at least on the solace broker, that could be fixed.  (not sure if this is the right place to discuss those though)
   I tried out the transaction sample which hung at rollback however the tests did not. I'm not sure why the interop tests do not work. None of the test seem to receive the message from the transaction.
   
   @HavretGC Have you tried the tests against a broker, or is that why you raise #9 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services