You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smitajoshi12 (via GitHub)" <gi...@apache.org> on 2023/10/18 11:45:13 UTC

[PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

smitajoshi12 opened a new pull request, #5461:
URL: https://github.com/apache/ozone/pull/5461

   
   ## What changes were proposed in this pull request?
   Recon UI - Disk Usage page should reflect the information it displays like currently it shows storage stats only for FSO buckets/paths. As of now currently it doesn't support OBS and LEGACY buckets. For supporting OBS and LEGACY buckets, work is in progress tracked by [HDDS-7810](https://issues.apache.org/jira/browse/HDDS-7810) . Till then page should show that it displays storage stats only for FSO buckets/paths.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-9465
   
   ## How was this patch tested?
   Manually
   ![image](https://github.com/apache/ozone/assets/112169209/f0c710a2-d6b4-469f-b4b1-0529c4904ab1)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5461:
URL: https://github.com/apache/ozone/pull/5461#issuecomment-1785439325

   Thanks for working on this @smitajoshi12, thanks for the review @devmadhuu and @devabhishekpal! I didn't wait for others review, later we can change it, but currently there is also an ongoing effort to support not just FSO buckets, so after that we will remove this tooltip :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5461:
URL: https://github.com/apache/ozone/pull/5461#issuecomment-1778953407

   @smitajoshi12 could you update the screenshot in the PR description to the latest approach? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on code in PR #5461:
URL: https://github.com/apache/ozone/pull/5461#discussion_r1363764836


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/diskUsage/diskUsage.tsx:
##########
@@ -18,7 +18,7 @@
 
 import React from 'react';
 import Plot from 'react-plotly.js';
-import {Row, Col, Icon, Button, Input, Menu, Dropdown} from 'antd';
+import {Row, Col, Icon, Button, Input, Menu, Dropdown,Tooltip} from 'antd';

Review Comment:
   nit
   ```suggestion
   import {Row, Col, Icon, Button, Input, Menu, Dropdown, Tooltip} from 'antd';
   ```



##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/diskUsage/diskUsage.tsx:
##########
@@ -539,7 +539,10 @@ export class DiskUsage extends React.Component<Record<string, object>, IDUState>
     return (
       <div className='du-container'>
         <div className='page-header'>
-          Disk Usage
+          Disk Usage&nbsp;&nbsp;
+          <Tooltip placement="rightTop" title="Shows Disk Usage Info for FSO buckets Only">

Review Comment:
   ```suggestion
             <Tooltip placement="rightTop" title="Shows Disk Usage information only for FSO buckets">
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5461:
URL: https://github.com/apache/ozone/pull/5461#discussion_r1363823628


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/diskUsage/diskUsage.tsx:
##########
@@ -18,7 +18,7 @@
 
 import React from 'react';
 import Plot from 'react-plotly.js';
-import {Row, Col, Icon, Button, Input, Menu, Dropdown} from 'antd';
+import {Row, Col, Icon, Button, Input, Menu, Dropdown,Tooltip} from 'antd';

Review Comment:
   @dombizita 
   Completed Change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5461:
URL: https://github.com/apache/ozone/pull/5461#discussion_r1363815891


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/diskUsage/diskUsage.tsx:
##########
@@ -539,7 +539,10 @@ export class DiskUsage extends React.Component<Record<string, object>, IDUState>
     return (
       <div className='du-container'>
         <div className='page-header'>
-          Disk Usage
+          Disk Usage&nbsp;&nbsp;
+          <Tooltip placement="rightTop" title="Shows Disk Usage Info for FSO buckets Only">

Review Comment:
   @dombizita 
   Created  SubTask under this JIRA https://issues.apache.org/jira/browse/HDDS-5305 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on code in PR #5461:
URL: https://github.com/apache/ozone/pull/5461#discussion_r1363736216


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/diskUsage/diskUsage.tsx:
##########
@@ -539,7 +539,10 @@ export class DiskUsage extends React.Component<Record<string, object>, IDUState>
     return (
       <div className='du-container'>
         <div className='page-header'>
-          Disk Usage
+          Disk Usage&nbsp;&nbsp;
+          <Tooltip placement="rightTop" title="Shows Disk Usage Info for FSO buckets Only">

Review Comment:
   LGTM +1, however pls add a task in [HDDS-7810](https://issues.apache.org/jira/browse/HDDS-7810)  to remove back this tool tip once [HDDS-7810](https://issues.apache.org/jira/browse/HDDS-7810) is resolved along with it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5461:
URL: https://github.com/apache/ozone/pull/5461#issuecomment-1785411093

   > > @smitajoshi12 could you update the screenshot in the PR description to the latest approach?
   > 
   > @dombizita I have added new screenshot with before this PR and after this PR.
   
   I know, but after the review changes the content changed, I wanted to have the latest version in the PR description (_Shows Disk Usage information only for FSO buckets_).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita merged PR #5461:
URL: https://github.com/apache/ozone/pull/5461


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on PR #5461:
URL: https://github.com/apache/ozone/pull/5461#issuecomment-1779069257

   > @smitajoshi12 could you update the screenshot in the PR description to the latest approach?
   
   @dombizita 
   I have added new screenshot with before this PR and after this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5461:
URL: https://github.com/apache/ozone/pull/5461#issuecomment-1778952711

   Could you take a look at it @umamaheswararao @DaveTeng0? Do you think is this a good solution to avoid confusion?  Thanks in advance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5461:
URL: https://github.com/apache/ozone/pull/5461#issuecomment-1768336469

   Could you also take a look at this @DaveTeng0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9465. Recon UI - Disk Usage page should reflect the information it displays [ozone]

Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5461:
URL: https://github.com/apache/ozone/pull/5461#discussion_r1363824006


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/diskUsage/diskUsage.tsx:
##########
@@ -539,7 +539,10 @@ export class DiskUsage extends React.Component<Record<string, object>, IDUState>
     return (
       <div className='du-container'>
         <div className='page-header'>
-          Disk Usage
+          Disk Usage&nbsp;&nbsp;
+          <Tooltip placement="rightTop" title="Shows Disk Usage Info for FSO buckets Only">

Review Comment:
   @dombizita 
   Completed Change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org