[GitHub] incubator-usergrid pull request: Usergrid 323 windows phone notifi...

[tnine <gi...@git.apache.org>]

Github user tnine commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/153#discussion_r23487449
  
    --- Diff: stack/services/src/main/java/org/apache/usergrid/services/notifications/ProviderAdapterFactory.java ---
    @@ -37,6 +38,7 @@ public static ProviderAdapter getProviderAdapter(Notifier notifier, EntityManage
            switch(notifier.getProvider().toLowerCase()){
                case "apple" : adapter = new APNsAdapter(entityManager,notifier); break;
                case "google" : adapter = new GCMAdapter(entityManager ,notifier); break;
    +           case "windows" : adapter = new WNSAdapter(entityManager ,notifier); break;
                case "noop" : adapter = new TestAdapter(notifier); break;
    --- End diff --
    
    Seems silly, but I think our default case should be to throw an exception if it doesn't match any of the other cases.  That way we get some explicit feedback something was entered incorrectly into the payload.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---