You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Hyrum K. Wright" <hy...@mail.utexas.edu> on 2007/05/31 18:27:50 UTC
Re: svn commit: r25240 - trunk/subversion/include
blair@tigris.org wrote:
> Author: blair
> Date: Thu May 31 11:18:50 2007
> New Revision: 25240
>
> Log:
> * subversion/include/svn_repos.h:
> Style fix, associate remove the space between the * and the function
> name to match the rest of the file.
>
>
> Modified:
> trunk/subversion/include/svn_repos.h
>
> Modified: trunk/subversion/include/svn_repos.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_repos.h?pathrev=25240&r1=25239&r2=25240
> ==============================================================================
> --- trunk/subversion/include/svn_repos.h (original)
> +++ trunk/subversion/include/svn_repos.h Thu May 31 11:18:50 2007
> @@ -228,10 +228,10 @@
> * means deleting copied, unused logfiles for a Berkeley DB source
> * repository.
> */
> -svn_error_t * svn_repos_hotcopy(const char *src_path,
> - const char *dst_path,
> - svn_boolean_t clean_logs,
> - apr_pool_t *pool);
> +svn_error_t *svn_repos_hotcopy(const char *src_path,
> + const char *dst_path,
> + svn_boolean_t clean_logs,
> + apr_pool_t *pool);
Actually, I thought our style would dictate:
svn_error_t *
svn_repos_hotcopy(const char *src_path,
const char *dst_path,
svn_boolean_t clean_logs,
apr_pool_t *pool);
But, I don't think that's followed very closely in some places.
-Hyrum
Re: svn commit: r25240 - trunk/subversion/include
Posted by Daniel Rall <dl...@collab.net>.
On Thu, 31 May 2007, Blair Zajac wrote:
> Hyrum K. Wright wrote:
> >blair@tigris.org wrote:
> >>Author: blair
> >>Date: Thu May 31 11:18:50 2007
> >>New Revision: 25240
> >>
> >>Log:
> >>* subversion/include/svn_repos.h:
> >> Style fix, associate remove the space between the * and the function
> >> name to match the rest of the file.
> >>
> >>
> >>Modified:
> >> trunk/subversion/include/svn_repos.h
> >>
> >>Modified: trunk/subversion/include/svn_repos.h
> >>URL:
> >>http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_repos.h?pathrev=25240&r1=25239&r2=25240
> >>==============================================================================
> >>--- trunk/subversion/include/svn_repos.h (original)
> >>+++ trunk/subversion/include/svn_repos.h Thu May 31 11:18:50 2007
> >>@@ -228,10 +228,10 @@
> >> * means deleting copied, unused logfiles for a Berkeley DB source
> >> * repository.
> >> */
> >>-svn_error_t * svn_repos_hotcopy(const char *src_path,
> >>- const char *dst_path,
> >>- svn_boolean_t clean_logs,
> >>- apr_pool_t *pool);
> >>+svn_error_t *svn_repos_hotcopy(const char *src_path,
> >>+ const char *dst_path,
> >>+ svn_boolean_t clean_logs,
> >>+ apr_pool_t *pool);
> >
> >Actually, I thought our style would dictate:
> >svn_error_t *
> >svn_repos_hotcopy(const char *src_path,
> > const char *dst_path,
> > svn_boolean_t clean_logs,
> > apr_pool_t *pool);
> >
> >But, I don't think that's followed very closely in some places.
> >
> >-Hyrum
>
> Checking the hacking document, yes, that's correct. Before I read
> checked it, I was under the impression that if the function name and its
> arguments extend past 80 characters, then you wrap to the next line,
> otherwise, you keep on the same line.
I do prefer them on separate lines.
Re: svn commit: r25240 - trunk/subversion/include
Posted by Blair Zajac <bl...@orcaware.com>.
Hyrum K. Wright wrote:
> blair@tigris.org wrote:
>> Author: blair
>> Date: Thu May 31 11:18:50 2007
>> New Revision: 25240
>>
>> Log:
>> * subversion/include/svn_repos.h:
>> Style fix, associate remove the space between the * and the function
>> name to match the rest of the file.
>>
>>
>> Modified:
>> trunk/subversion/include/svn_repos.h
>>
>> Modified: trunk/subversion/include/svn_repos.h
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_repos.h?pathrev=25240&r1=25239&r2=25240
>> ==============================================================================
>> --- trunk/subversion/include/svn_repos.h (original)
>> +++ trunk/subversion/include/svn_repos.h Thu May 31 11:18:50 2007
>> @@ -228,10 +228,10 @@
>> * means deleting copied, unused logfiles for a Berkeley DB source
>> * repository.
>> */
>> -svn_error_t * svn_repos_hotcopy(const char *src_path,
>> - const char *dst_path,
>> - svn_boolean_t clean_logs,
>> - apr_pool_t *pool);
>> +svn_error_t *svn_repos_hotcopy(const char *src_path,
>> + const char *dst_path,
>> + svn_boolean_t clean_logs,
>> + apr_pool_t *pool);
>
> Actually, I thought our style would dictate:
> svn_error_t *
> svn_repos_hotcopy(const char *src_path,
> const char *dst_path,
> svn_boolean_t clean_logs,
> apr_pool_t *pool);
>
> But, I don't think that's followed very closely in some places.
>
> -Hyrum
Checking the hacking document, yes, that's correct. Before I read
checked it, I was under the impression that if the function name and its
arguments extend past 80 characters, then you wrap to the next line,
otherwise, you keep on the same line.
Regards,
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org