[jira] [Commented] (GEODE-8956) LocatorMembershipListenerImpl has unconstrained thread creation that can crash a machine

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289280#comment-17289280 ] 

ASF GitHub Bot commented on GEODE-8956:
---------------------------------------

mivanac opened a new pull request #6048:
URL: https://github.com/apache/geode/pull/6048


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [*] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [*] Is your initial contribution a single, squashed commit?
   
   - [*] Does `gradlew build` run cleanly?
   
   - [*] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> LocatorMembershipListenerImpl has unconstrained thread creation that can crash a machine
> ----------------------------------------------------------------------------------------
>
>                 Key: GEODE-8956
>                 URL: https://issues.apache.org/jira/browse/GEODE-8956
>             Project: Geode
>          Issue Type: Bug
>          Components: wan
>            Reporter: Bruce J Schuchardt
>            Assignee: Mario Ivanac
>            Priority: Major
>
> In reviewing PR 6013 I found that a simple change meant to resolve a difficult problem lead to unrestrained thread growth, sometimes topping out at over 5000 threads, in a locator that often crashed the host machine.  The thread growth was due to this method in LocatorMembershipListenerImpl:
> {code:java}
> Thread buildLocatorsDistributorThread(DistributionLocatorId localLocatorId,
>     Map<Integer, Set<DistributionLocatorId>> remoteLocators, DistributionLocatorId joiningLocator,
>     int joiningLocatorDistributedSystemId) {
>   Runnable distributeLocatorsRunnable =
>       new DistributeLocatorsRunnable(config.getMemberTimeout(), tcpClient, localLocatorId,
>           remoteLocators, joiningLocator, joiningLocatorDistributedSystemId);
>   ThreadFactory threadFactory = new LoggingThreadFactory(LOCATORS_DISTRIBUTOR_THREAD_NAME, true);
>   return threadFactory.newThread(distributeLocatorsRunnable);
> }
> {code}
> This should probably be performed in an Executor with a reasonable max-threads limit based on the number of local and remote-locators in the DistributionConfig.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)