You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "shuoer86 (via GitHub)" <gi...@apache.org> on 2023/10/18 13:25:59 UTC
[PR] Fix typos [spark]
shuoer86 opened a new pull request, #43434:
URL: https://github.com/apache/spark/pull/43434
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix typos [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43434:
URL: https://github.com/apache/spark/pull/43434#issuecomment-1768495669
Can you find more while you're at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR] Fix typos [spark]
Posted by "shuoer86 (via GitHub)" <gi...@apache.org>.
shuoer86 commented on code in PR #43434:
URL: https://github.com/apache/spark/pull/43434#discussion_r1366917399
##########
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala:
##########
@@ -79,7 +79,7 @@ private[spark] class DiskBlockManager(
private val shutdownHook = addShutdownHook()
// If either of these features are enabled, we must change permissions on block manager
- // directories and files to accomodate the shuffle service deleting files in a secure environment.
+ // directories and files to accommodate the shuffle service deleting files in a secure environment.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix typos [spark]
Posted by "shuoer86 (via GitHub)" <gi...@apache.org>.
shuoer86 commented on PR #43434:
URL: https://github.com/apache/spark/pull/43434#issuecomment-1768588692
I can find more but I don't know which are needed to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix typos [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #43434:
URL: https://github.com/apache/spark/pull/43434#discussion_r1364710307
##########
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala:
##########
@@ -79,7 +79,7 @@ private[spark] class DiskBlockManager(
private val shutdownHook = addShutdownHook()
// If either of these features are enabled, we must change permissions on block manager
- // directories and files to accomodate the shuffle service deleting files in a secure environment.
+ // directories and files to accommodate the shuffle service deleting files in a secure environment.
Review Comment:
See the test failure results. This line is too long now
`[error] /home/runner/work/spark/spark/core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala:82: File line length exceeds 100 characters`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR] Fix typos [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43434:
URL: https://github.com/apache/spark/pull/43434#issuecomment-1773928477
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR] Fix typos [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #43434: [MINOR] Fix typos
URL: https://github.com/apache/spark/pull/43434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix typos [spark]
Posted by "shuoer86 (via GitHub)" <gi...@apache.org>.
shuoer86 commented on PR #43434:
URL: https://github.com/apache/spark/pull/43434#issuecomment-1768612309
I have found more and that's all. @srowen Please help me to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org