[jira] Resolved: (TOMAHAWK-882) missing setNodeId(null) in processDecodes()

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/TOMAHAWK-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved TOMAHAWK-882.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.8-SNAPSHOT

After doing some probes and compare other processXXX methods, it is clear that setNodeId(null) should be executed at the end of processDecodes. The bug has no side effects for the casual user (in fact it is noted only in some very specific code). It is similar to the behavior of setRowIndex on UIData components.

> missing setNodeId(null) in processDecodes()
> -------------------------------------------
>
>                 Key: TOMAHAWK-882
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-882
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Tree2
>    Affects Versions: 1.1.5-SNAPSHOT
>            Reporter: Tobias Haubner
>            Assignee: Leonardo Uribe
>            Priority: Critical
>             Fix For: 1.1.8-SNAPSHOT
>
>
> At the end of processDecodes() in HtmlTree, nodeId is not set back to null. 
> This leads to the tree returning the id of a node, not the id of the tree, when calling getClientId() after processDecodes().
> This e.g. affects AJAX calls from within the tree.
> processUpdates() and processValidators() are correct.
> To avoid such errors in the future it would be even better to change TreeWalkerBase to set nodeId=null at the end of its walk (i.e. in the next() method if next() is false).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.