You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/04/05 22:35:30 UTC

[GitHub] [superset] john-bodley commented on a diff in pull request #23597: fix: Ensure verbose mapping exists for SQL Lab Query model

john-bodley commented on code in PR #23597:
URL: https://github.com/apache/superset/pull/23597#discussion_r1159089897


##########
superset/models/sql_lab.py:
##########
@@ -246,6 +246,7 @@ def data(self) -> Dict[str, Any]:
             "database": {"id": self.database_id, "backend": self.database.backend},
             "order_by_choices": order_by_choices,
             "schema": self.schema,
+            "verbose_map": {},

Review Comment:
   Present [here](https://github.com/apache/superset/blob/56dcf25cf8ac5ed47235ebacde07200ccba257b3/superset/connectors/base/models.py#L293) for the `superset.connectors.base.models.BaseDatasource` model.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org