[GitHub] [spark] cloud-fan commented on a diff in pull request #38745: [SPARK-37099][SQL] Optimize the filter based on rank-like window function by reduce not required rows

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #38745:
URL: https://github.com/apache/spark/pull/38745#discussion_r1031159165


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala:
##########
@@ -87,7 +88,8 @@ case class WindowExec(
     windowExpression: Seq[NamedExpression],
     partitionSpec: Seq[Expression],
     orderSpec: Seq[SortOrder],
-    child: SparkPlan)
+    child: SparkPlan,
+    groupLimitInfo: Option[(Int, Expression)] = None)

Review Comment:
   I think it's overkill and very risky to make invasive changes to a fundamental physical operator like `WindownExec`. I like https://github.com/apache/spark/pull/34367 more which adds a new physical node. Can you elaborate on why is this better than https://github.com/apache/spark/pull/34367 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org