You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/09/01 08:39:00 UTC

[GitHub] [commons-lang] GaliFFun opened a new pull request #615: [LANG-1606] StringUtils.countMatches returns incorrect value while handling intersecting substrings

GaliFFun opened a new pull request #615:
URL: https://github.com/apache/commons-lang/pull/615


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] sebbASF closed pull request #615: [LANG-1606] StringUtils.countMatches returns incorrect value while handling intersecting substrings

Posted by GitBox <gi...@apache.org>.
sebbASF closed pull request #615:
URL: https://github.com/apache/commons-lang/pull/615


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] coveralls commented on pull request #615: [LANG-1606] StringUtils.countMatches returns incorrect value while handling intersecting substrings

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #615:
URL: https://github.com/apache/commons-lang/pull/615#issuecomment-684657016


   
   [![Coverage Status](https://coveralls.io/builds/33139811/badge)](https://coveralls.io/builds/33139811)
   
   Coverage remained the same at 94.705% when pulling **14e88e0a96f7b63302574f7a9a2d2996766c6aba on GaliFFun:LANG-1606-countMatches** into **649dedbbe8b6ab61fb3c4792c86b7e0af7ec4a73 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] sebbASF commented on pull request #615: [LANG-1606] StringUtils.countMatches returns incorrect value while handling intersecting substrings

Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #615:
URL: https://github.com/apache/commons-lang/pull/615#issuecomment-684807243


   Thanks for the PR, but it is the Javadoc that must be fixed, not the code.
   If necessary, raise a separate issue for the a version of the method that supports counting overlapping occurrences.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org