You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/07/11 21:16:34 UTC
[kudu-CR] [docs] Fix quickstart IP one liner
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13848
Change subject: [docs] Fix quickstart IP one liner
......................................................................
[docs] Fix quickstart IP one liner
It was reported that on Linux an extra whitespace could
be included breaking the one liner. This uses `awk` instead
so exact spaces don't matter.
Change-Id: Ie401578da12157b802752ff62885c4b4dc6b3a29
---
M docs/quickstart.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/13848/1
--
To view, visit http://gerrit.cloudera.org:8080/13848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie401578da12157b802752ff62885c4b4dc6b3a29
Gerrit-Change-Number: 13848
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docs] Fix quickstart IP one liner
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13848 )
Change subject: [docs] Fix quickstart IP one liner
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie401578da12157b802752ff62885c4b4dc6b3a29
Gerrit-Change-Number: 13848
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Jul 2019 21:52:40 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Fix quickstart IP one liner
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13848 )
Change subject: [docs] Fix quickstart IP one liner
......................................................................
[docs] Fix quickstart IP one liner
It was reported that on Linux an extra whitespace could
be included breaking the one liner. This uses `awk` instead
so exact spaces don't matter.
Change-Id: Ie401578da12157b802752ff62885c4b4dc6b3a29
Reviewed-on: http://gerrit.cloudera.org:8080/13848
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docs/quickstart.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Grant Henke: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie401578da12157b802752ff62885c4b4dc6b3a29
Gerrit-Change-Number: 13848
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] Fix quickstart IP one liner
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13848 )
Change subject: [docs] Fix quickstart IP one liner
......................................................................
Patch Set 1: Code-Review+2
Works for me on mac
--
To view, visit http://gerrit.cloudera.org:8080/13848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie401578da12157b802752ff62885c4b4dc6b3a29
Gerrit-Change-Number: 13848
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 12 Jul 2019 18:01:13 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Fix quickstart IP one liner
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [docs] Fix quickstart IP one liner
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie401578da12157b802752ff62885c4b4dc6b3a29
Gerrit-Change-Number: 13848
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)