You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Russell Black (Created) (JIRA)" <ji...@apache.org> on 2012/03/03 01:15:59 UTC
[jira] [Created] (SOLR-3196) partialResults response header not
propagated in distributed search
partialResults response header not propagated in distributed search
-------------------------------------------------------------------
Key: SOLR-3196
URL: https://issues.apache.org/jira/browse/SOLR-3196
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 3.5, 4.0
Reporter: Russell Black
For {{timeAllowed=true}} requests, the response contains a {{partialResults}} header that indicates when a search was terminated early due to running out of time. This header is being discarded by the collator. Patch to follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3196) partialResults response header not
propagated in distributed search
Posted by "Mark Miller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221510#comment-13221510 ]
Mark Miller commented on SOLR-3196:
-----------------------------------
Nice, thanks guys. We should prob add a simple test too - I can probably take this issue on if no one else jumps on it.
> partialResults response header not propagated in distributed search
> -------------------------------------------------------------------
>
> Key: SOLR-3196
> URL: https://issues.apache.org/jira/browse/SOLR-3196
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.5, 4.0
> Reporter: Russell Black
> Labels: patch
> Attachments: SOLR-3196-partialResults-header.patch
>
>
> For {{timeAllowed=true}} requests, the response contains a {{partialResults}} header that indicates when a search was terminated early due to running out of time. This header is being discarded by the collator. Patch to follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3196) partialResults response header not
propagated in distributed search
Posted by "Russell Black (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223789#comment-13223789 ]
Russell Black commented on SOLR-3196:
-------------------------------------
I looked into writing a test case for this, but ran into some difficulties. The problem is that for the small data sets used by the test cases, all queries return within 1 millisecond, so I can't force the timeout. (1 ms is the lowest value supported for the timeAllowed parameter, passing 0 is the same as not passing a timeout). I haven't been able to come up with a query that takes sufficiently long to test {{timeAllowed}}. It appears that there are no test cases that test for the presence of the {{partialResults}} header even for non-distributed searches. I am confident that this patch works, however, since I have tested it thoroughly in our own index. It's a pretty uncomplicated patch.
> partialResults response header not propagated in distributed search
> -------------------------------------------------------------------
>
> Key: SOLR-3196
> URL: https://issues.apache.org/jira/browse/SOLR-3196
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.5, 4.0
> Reporter: Russell Black
> Labels: patch
> Attachments: SOLR-3196-partialResults-header.patch
>
>
> For {{timeAllowed=true}} requests, the response contains a {{partialResults}} header that indicates when a search was terminated early due to running out of time. This header is being discarded by the collator. Patch to follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3196) partialResults response header not
propagated in distributed search
Posted by "Erick Erickson (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson resolved SOLR-3196.
----------------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.6
4.x r: 1301097
3.6 r: 1301096
Right, after looking a bit more closely, there's nothing here that would break back-compat, that was just my paranoia was at work.
> partialResults response header not propagated in distributed search
> -------------------------------------------------------------------
>
> Key: SOLR-3196
> URL: https://issues.apache.org/jira/browse/SOLR-3196
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.5, 4.0
> Reporter: Russell Black
> Labels: patch
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3196-3x.patch, SOLR-3196-partialResults-header.patch
>
>
> For {{timeAllowed=true}} requests, the response contains a {{partialResults}} header that indicates when a search was terminated early due to running out of time. This header is being discarded by the collator. Patch to follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3196) partialResults response header not
propagated in distributed search
Posted by "Russell Black (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224779#comment-13224779 ]
Russell Black commented on SOLR-3196:
-------------------------------------
Will it be possible to have this committed to 3x as well? The patch should apply just fine to the 3x branch and we'd love to have this make it into 3.6.
> partialResults response header not propagated in distributed search
> -------------------------------------------------------------------
>
> Key: SOLR-3196
> URL: https://issues.apache.org/jira/browse/SOLR-3196
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.5, 4.0
> Reporter: Russell Black
> Labels: patch
> Attachments: SOLR-3196-partialResults-header.patch
>
>
> For {{timeAllowed=true}} requests, the response contains a {{partialResults}} header that indicates when a search was terminated early due to running out of time. This header is being discarded by the collator. Patch to follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3196) partialResults response header not
propagated in distributed search
Posted by "Russell Black (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228513#comment-13228513 ]
Russell Black commented on SOLR-3196:
-------------------------------------
Erick,
Thanks for trying, i'll take a look at what's going on.
> partialResults response header not propagated in distributed search
> -------------------------------------------------------------------
>
> Key: SOLR-3196
> URL: https://issues.apache.org/jira/browse/SOLR-3196
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.5, 4.0
> Reporter: Russell Black
> Labels: patch
> Attachments: SOLR-3196-3x.patch, SOLR-3196-partialResults-header.patch
>
>
> For {{timeAllowed=true}} requests, the response contains a {{partialResults}} header that indicates when a search was terminated early due to running out of time. This header is being discarded by the collator. Patch to follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3196) partialResults response header not
propagated in distributed search
Posted by "Russell Black (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228573#comment-13228573 ]
Russell Black commented on SOLR-3196:
-------------------------------------
I'm not sure why the original patch fails to apply to 3x. However, your patch looks good to me.
I don't see any problems with backwards compatibility. This patch has the effect of adding a {{partialResults true}} header, making it behave the same as a non-distributed request for time limited queries. It's hard for me to imagine a situation where this would break backwards-compatibility.
> partialResults response header not propagated in distributed search
> -------------------------------------------------------------------
>
> Key: SOLR-3196
> URL: https://issues.apache.org/jira/browse/SOLR-3196
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.5, 4.0
> Reporter: Russell Black
> Labels: patch
> Attachments: SOLR-3196-3x.patch, SOLR-3196-partialResults-header.patch
>
>
> For {{timeAllowed=true}} requests, the response contains a {{partialResults}} header that indicates when a search was terminated early due to running out of time. This header is being discarded by the collator. Patch to follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3196) partialResults response header not
propagated in distributed search
Posted by "Russell Black (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Russell Black updated SOLR-3196:
--------------------------------
Attachment: SOLR-3196-partialResults-header.patch
> partialResults response header not propagated in distributed search
> -------------------------------------------------------------------
>
> Key: SOLR-3196
> URL: https://issues.apache.org/jira/browse/SOLR-3196
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.5, 4.0
> Reporter: Russell Black
> Labels: patch
> Attachments: SOLR-3196-partialResults-header.patch
>
>
> For {{timeAllowed=true}} requests, the response contains a {{partialResults}} header that indicates when a search was terminated early due to running out of time. This header is being discarded by the collator. Patch to follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3196) partialResults response header not
propagated in distributed search
Posted by "Erick Erickson (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated SOLR-3196:
---------------------------------
Attachment: SOLR-3196-3x.patch
Patch didn't apply to 3x, apparently a few things moved around.
Russel:
Could you take a quick check and see if this looks OK for 3x?
Any back-compat issues with changing what comes back in the responseHeader?
> partialResults response header not propagated in distributed search
> -------------------------------------------------------------------
>
> Key: SOLR-3196
> URL: https://issues.apache.org/jira/browse/SOLR-3196
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.5, 4.0
> Reporter: Russell Black
> Labels: patch
> Attachments: SOLR-3196-3x.patch, SOLR-3196-partialResults-header.patch
>
>
> For {{timeAllowed=true}} requests, the response contains a {{partialResults}} header that indicates when a search was terminated early due to running out of time. This header is being discarded by the collator. Patch to follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org