You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/09/24 21:11:14 UTC

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

GitHub user borisroman opened a pull request:

    https://github.com/apache/cloudstack/pull/886

    [FUTURE]CLOUDSTACK-8907: POD Gateway optional

    A gateway might not always be available. For instance, when the management network is an isolated network without internet access or inter domain/vlan routing.
    
    How to test:
    1. Deploy ACS
    2. Add POD without gateway.
    3. Let the systemvms deploy -> They don't have a gateway but can correctly connect to the management server.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8907

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #886
    
----
commit f64bc58ee92eb3c895b3a32489ea1c6dfddc6c9a
Author: Boris Schrijver <bo...@pcextreme.nl>
Date:   2015-09-24T11:16:46Z

    Made gateway optional when creating pod.

commit 186c50bddf35e351b77d3759fddfb0c3e65cf46d
Author: Boris Schrijver <bo...@pcextreme.nl>
Date:   2015-09-24T18:15:46Z

    Removed double pod gateway definition.
    
    Updated editPod() to accept null gateway.

commit acaf49f979b54e108d6710d867d561bd82a7f066
Author: Boris Schrijver <bo...@pcextreme.nl>
Date:   2015-09-24T18:38:41Z

    Fixed some finalizeVirtualMachineProfile() methods to handle null pod gateways.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:

    https://github.com/apache/cloudstack/pull/886#issuecomment-173185222
  
    When the network stack get's refactored this won't be necessary anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:

    https://github.com/apache/cloudstack/pull/886#issuecomment-143153417
  
    @wido I've force pushed my last commit to let Travis rerun the tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/886#issuecomment-158676481
  
    @borisroman Can you have a look and resolve the conflict? When we find another reviewer we can merge this in 4.7. Pinging @DaanHoogland @bhaisaab 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/886#issuecomment-158684576
  
    code looks good but I don't see the use case; in an isolated network without internet access there would still be a gateway, would there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/886#issuecomment-143148262
  
    Seems good to me, in Basic Networking it's not always required.
    
    I see that Travis CI timed out, any reason for that?
    
    Based on the code a LGTM from me, I've run into this multiple times.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:

    https://github.com/apache/cloudstack/pull/886#issuecomment-143160853
  
    @wido Travis passing fine now.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Posted by borisroman <gi...@git.apache.org>.
Github user borisroman closed the pull request at:

    https://github.com/apache/cloudstack/pull/886


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---