You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/03 01:03:56 UTC
[jira] [Commented] (OOZIE-783) Upgrade to junit4
[ https://issues.apache.org/jira/browse/OOZIE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266993#comment-13266993 ]
jiraposter@reviews.apache.org commented on OOZIE-783:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/
-----------------------------------------------------------
(Updated 2012-05-02 23:03:02.871145)
Review request for oozie and Alejandro Abdelnur.
Changes
-------
Addressing comments. Changes made to pom file only
Summary
-------
Changes:
1) @Test, @After, @Before annotations added
2) extends TestCase removed
3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
4) Junit 4 has a different way to obtain testcase method name; added in XTestCase
This addresses bug oozie-783.
https://issues.apache.org/jira/browse/oozie-783
Diffs (updated)
-----
trunk/pom.xml 1333119
Diff: https://reviews.apache.org/r/4618/diff
Testing
-------
Ran bin/mkdistro
Thanks,
Virag
> Upgrade to junit4
> -----------------
>
> Key: OOZIE-783
> URL: https://issues.apache.org/jira/browse/OOZIE-783
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> Following things are required from migrating:
> 1) Add @Test annotation to each test
> 2) "extends TestCase" should be removed in XTestCase
> 3) @Before and @After annotations for setUp() and tearDown()
> @Before
> public void setUp() throws Exception { }
> @After
> public void tearDown() throws Exception { }
> 4) Some changes to imports required
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira