You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/18 16:48:32 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
gaozhangmin opened a new pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351
### Motivation
Enable CheckStyle plugin in
pulsar-functions-worker
### Modifications
Fix the wrong code style in pulsar-functions-worker module.
### Verifying this change
The maven-checkstyle-plugin is added to pom.xml so
that the code style will be checked in mvn clean install.
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1042950239
@gaozhangmin:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin edited a comment on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1047660195
ping @eolivelli @Shoothzj @BewareMyPower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1044821282
> ### Motivation
> Enable CheckStyle plugin in pulsar-functions-worker pulsar-functions-api-example pulsar-functions-local-runner-origin pulsar-functions-local-runner pulsar-functions-proto pulsar-functions-runtime pulsar-functions-runtime-all pulsar-functions-utils pulsar-functions-secrets
>
> ### Modifications
> Fix the wrong code style in pulsar-functions-worker module.
>
> ### Verifying this change
> The maven-checkstyle-plugin is added to pom.xml so that the code style will be checked in mvn clean install.
>
> ### Documentation
> Check the box below or label this PR directly (if you have committer privilege).
>
> Need to update docs?
>
> * [ ] `doc-required`
> (If you need help on updating docs, create a doc issue)
> * [x] `no-need-doc`
> (Please explain why)
> * [ ] `doc`
> (If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1044387037
>
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1046002640
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1046010038
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1043051131
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1043951095
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1047660195
ping @lhotari @Shoothzj @BewareMyPower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower merged pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1044387037
>
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin closed pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin closed pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1046010038
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1045991743
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1045991743
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1044821282
> ### Motivation
> Enable CheckStyle plugin in pulsar-functions-worker pulsar-functions-api-example pulsar-functions-local-runner-origin pulsar-functions-local-runner pulsar-functions-proto pulsar-functions-runtime pulsar-functions-runtime-all pulsar-functions-utils pulsar-functions-secrets
>
> ### Modifications
> Fix the wrong code style in pulsar-functions-worker module.
>
> ### Verifying this change
> The maven-checkstyle-plugin is added to pom.xml so that the code style will be checked in mvn clean install.
>
> ### Documentation
> Check the box below or label this PR directly (if you have committer privilege).
>
> Need to update docs?
>
> * [ ] `doc-required`
> (If you need help on updating docs, create a doc issue)
> * [x] `no-need-doc`
> (Please explain why)
> * [ ] `doc`
> (If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1043895206
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14351:
URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1042912843
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org