You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2026/05/23 00:01:59 UTC
(superset) branch claude/subdirectory-helpers-tdd updated (4dd4131d47e -> 5b5f98af206)
This is an automated email from the ASF dual-hosted git repository.
sadpandajoe pushed a change to branch claude/subdirectory-helpers-tdd
in repository https://gitbox.apache.org/repos/asf/superset.git
omit 4dd4131d47e fix(subdirectory): route get_redirect_url query through url_for to satisfy CodeQL
add 9141324715e fix(security): harden navigation guards against backslash open-redirects
add fbd07afdc96 fix(subdirectory): retire /superset/welcome/ dead route in FileHandler
add 8692b6e817d fix(subdirectory): migrate RAW_HREF callsites and drop allowlist (Slice 3a)
add 963312ee45d fix(subdirectory): migrate direct DOM navigation to navigationUtils helpers
add 7e093a2e2af fix(subdirectory): migrate HARDCODED /superset literals (Slice 3c)
add 1bc20f2206c fix(subdirectory): lift get_redirect_url helper + harden against AF-2/AF-3 (Slice 4)
add 5b5f98af206 fix(subdirectory): add LegacyPrefixRedirectMiddleware 308 shim (Slice 5)
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (4dd4131d47e)
\
N -- N -- N refs/heads/claude/subdirectory-helpers-tdd (5b5f98af206)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
UPDATING.md | 6 +
.../src/chart/clients/ChartClient.ts | 4 +-
.../src/chart/components/StatefulChart.tsx | 4 +-
.../src/query/api/legacy/getDatasourceMetadata.ts | 2 +-
.../test/chart/clients/ChartClient.test.ts | 26 +-
.../query/api/legacy/getDatasourceMetadata.test.ts | 4 +-
.../src/SqlLab/components/ResultSet/index.tsx | 10 +-
.../SqlLab/components/SaveDatasetModal/index.tsx | 7 +-
.../DatasourceEditor/DatasourceEditor.tsx | 7 +-
.../DashboardLinksExternal.test.tsx | 10 +-
.../components/DashboardLinksExternal/index.tsx | 2 +-
.../src/components/ListView/CrossLinks.test.tsx | 7 +-
.../src/components/ListView/CrossLinks.tsx | 2 +-
.../src/dashboard/actions/datasources.ts | 2 +-
.../components/nativeFilters/FilterBar/index.tsx | 6 +-
.../AnnotationLayerControl/AnnotationLayer.tsx | 3 +-
.../src/explore/exploreUtils/exploreUtils.test.tsx | 22 +-
.../src/explore/exploreUtils/exportChart.test.ts | 17 +-
.../src/explore/exploreUtils/getExploreUrl.test.ts | 10 +-
.../explore/exploreUtils/getURIDirectory.test.ts | 6 +-
.../src/explore/exploreUtils/index.ts | 2 +-
.../src/pages/AnnotationLayerList/index.tsx | 6 +-
.../src/pages/AnnotationList/index.tsx | 3 +-
superset-frontend/src/pages/DatabaseList/index.tsx | 7 +-
superset-frontend/src/pages/DatasetList/index.tsx | 7 +-
.../FileHandler/FileHandler.subdirectory.test.tsx | 267 +++++++++++
.../src/pages/FileHandler/index.test.tsx | 10 +-
superset-frontend/src/pages/FileHandler/index.tsx | 10 +-
superset-frontend/src/pages/Login/index.tsx | 3 +-
.../pages/RedirectWarning/RedirectWarning.test.tsx | 78 ++++
.../src/pages/RedirectWarning/index.tsx | 31 ++
.../src/pages/RedirectWarning/utils.test.ts | 46 ++
.../src/pages/RedirectWarning/utils.ts | 11 +-
superset-frontend/src/pages/Register/index.tsx | 7 +-
superset-frontend/src/pages/Tags/index.tsx | 2 +-
superset-frontend/src/preamble.ts | 2 +-
.../src/utils/navigationUtils.appRoot.test.tsx | 135 ++++++
.../src/utils/navigationUtils.directDom.test.tsx | 244 ++++++++++
.../src/utils/navigationUtils.invariants.test.ts | 213 +++++++--
.../src/utils/navigationUtils.test.ts | 261 +++++++++++
superset-frontend/src/utils/navigationUtils.ts | 123 +++--
superset-frontend/src/utils/pathUtils.test.ts | 74 +++
superset-frontend/src/utils/pathUtils.ts | 11 +-
superset/app.py | 13 +
superset/connectors/sqla/models.py | 22 +-
.../common => superset/middleware}/__init__.py | 0
superset/middleware/legacy_prefix_redirect.py | 228 +++++++++
superset/views/core.py | 54 +--
superset/views/explore.py | 26 +-
superset/views/utils.py | 110 ++++-
.../views/test_explore_redirect.py | 251 ++++++++++
tests/unit_tests/initialization_test.py | 36 +-
.../unit_tests/middleware}/__init__.py | 0
.../middleware/test_legacy_prefix_redirect.py | 512 +++++++++++++++++++++
54 files changed, 2719 insertions(+), 243 deletions(-)
create mode 100644 superset-frontend/src/pages/FileHandler/FileHandler.subdirectory.test.tsx
create mode 100644 superset-frontend/src/pages/RedirectWarning/RedirectWarning.test.tsx
create mode 100644 superset-frontend/src/utils/navigationUtils.appRoot.test.tsx
create mode 100644 superset-frontend/src/utils/navigationUtils.directDom.test.tsx
copy {superset-core/src/superset_core/common => superset/middleware}/__init__.py (100%)
create mode 100644 superset/middleware/legacy_prefix_redirect.py
create mode 100644 tests/integration_tests/views/test_explore_redirect.py
copy {superset-core/src/superset_core/common => tests/unit_tests/middleware}/__init__.py (100%)
create mode 100644 tests/unit_tests/middleware/test_legacy_prefix_redirect.py